Open
Conversation
…ow an example of it
* Add options prop table
|
Please set a versioning label of either |
Contributor
Author
|
Remove internal state per previous discussion, pass in props |
jbkolze
requested changes
Sep 16, 2025
Contributor
jbkolze
left a comment
jbkolze
left a comment
There was a problem hiding this comment.
Had a comment on defaultValue. Looks good otherwise.
| className, | ||
| )} | ||
| value={value} | ||
| defaultValue={defaultValue} |
Contributor
There was a problem hiding this comment.
If the component is intended to be React-controlled I don't think we'd want to include a defaultValue. The default value would be handled by the useState hook for the variable being provided to value.
Contributor
There was a problem hiding this comment.
Did you intend to include this modal formatting in this PR?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Talking with @jbkolze he needed to be able to control dropdowns from outside the dropdown component.
This PR shows how that could be done while also maintaining a default of dropdowns state management for you. If you do not handle state by default, when value is not provided, this will break backwards compatibility. (Major Bump)
Documentation was updated to show both scenarios.
Marking as draft pending a larger conversation of not handling state in GW components.