227 groundwork links do not include base path on GitHub pages#228
227 groundwork links do not include base path on GitHub pages#228
Conversation
… are now not using doUpdateUrlWithBase and correct trailing slash.
|
Please set a versioning label of either |
willbreitkreutz
left a comment
willbreitkreutz
left a comment
There was a problem hiding this comment.
Will bring it up on the call, but i think we missed the base url in a few files, left a comment on each to keep track of them.
There was a problem hiding this comment.
import.meta.env.BASE_URL will reflect the env of the build-time, not consumer build time. I think we should expose a new prop on the breadcrumbs at the top level that allows you to pass in the base_url and default to "/".
There was a problem hiding this comment.
Resolved with #235, will come back for the rest!
There was a problem hiding this comment.
Same comment as on breadcrumbs
|
Need to review changes to groundwork-water and ensure we add the hash fix to onClick |
* Passing in additional headless ui props and updated documentation * Fixed all issues
* Add config to reference other libs * Add bug report * Add feature request
* Add baseUrl prop to Breadcrumbs component * Test baseUrl crumb prop against the doc site itself * Update the breadcrumbs docs to reflect prop changes
Co-authored-by: Charles Graham <charles.r.graham@usace>
Bumps [js-yaml](https://github.com/nodeca/js-yaml) from 4.1.0 to 4.1.1. - [Changelog](https://github.com/nodeca/js-yaml/blob/master/CHANGELOG.md) - [Commits](nodeca/js-yaml@4.1.0...4.1.1) --- updated-dependencies: - dependency-name: js-yaml dependency-version: 4.1.1 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 7.1.2 to 7.2.7. - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/v7.2.7/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/v7.2.7/packages/vite) --- updated-dependencies: - dependency-name: vite dependency-version: 7.2.7 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
3 participants
We got close with
#216
I missed a few things that i've found talking with @jbkolze.
In the current groundwork site it appears to be missing the base on the github pages. i.e.
/groundworkbut it does include the hash.This PR aims to fix this by adding the BASE_URL vite env variable. It also updates a few of the docs/places to talk more about the BASE_URL.