feat(api, dcs-loader, opendcs): user-defined goes telemetry#293
feat(api, dcs-loader, opendcs): user-defined goes telemetry#293dennisgsmith wants to merge 30 commits intodevelopfrom
Conversation
chore: allow <Database> parent element parsing
…platform config file
dennisgsmith
changed the title
MikeNeilson
left a comment
MikeNeilson
left a comment
There was a problem hiding this comment.
I've certainly seen, and likely created, worse hacks to get a legacy tool design function in a modernish way.
| <DataSourceGroupMember SequenceNum="0"> | ||
| <DataSource Name="cdadata" Type="lrgs"> | ||
| <DataSourceArg> | ||
| hostname=cdadata.wcda.noaa.gov, port=16003, password=${env.CDADATA_PASSWORD}, username=${env.CDADATA_USERNAME} |
There was a problem hiding this comment.
FYI can also encode the hostname as a variable.
It dawn on me we should give you access to the secret for the CWMS Hosted LRGS, it doesn't hook to cdadata yet (just public.lrgs.org) but that is the intention, I just need to configure it.
There was a problem hiding this comment.
Thanks for all the feedback @MikeNeilson !
I'm not sure we need to access CWMS (or at least not at the moment). This is specficially for Geotechnical instrumentation from my understanding. If any users specifically request CWMS Hosted LRGS we can reach out to get this configured.
opendcs/rsgis/pom.xml
Outdated
| <dependency> | ||
| <groupId>org.opendcs</groupId> | ||
| <artifactId>opendcs</artifactId> | ||
| <version>7.0.12</version> |
There was a problem hiding this comment.
Since this runs in the container primarily I just had it link against the opendcs.jar that already exists there. However, java is not a language I write too often, I'd be open to any recommendations you have on best practices.
There was a problem hiding this comment.
you should put these, specifically **/.settings in the .gitignore. I suspepect the .mvn but I'm not as familiar.
chore: gitignore eclipse **/.settings chore: set up validation types for dbimport api handler chore: add constrains for platform file keys
chore: do initial dbimport before staring routescheduler chore: configure logback to emit json logs chore: clean up mvn build process chore: move patch script to separate file
chore: hide internal endpoint from openapi doc chore: fix typos chore: fix staticcheck nested Queries warning
fix: incorrect request body validation when updating file alias
2 participants
feat: add apis for user-defined goes platform config uploads