Validation function updates#28
Open
wokenny13 wants to merge 11 commits into
Open
Conversation
|
coverage-report
Minimum allowed coverage is Generated by 🐒 cobertura-action against 11d0398 |
Remove export error function
|
Spelling check failed. Details: |
return a message for validating all columns in runAllValidations
Collaborator
Author
|
@ferribyh I made some updates to the validation functions in the TADACommunityHub as well as created a function to run all current existing validation functions for reviewing the allowable values within each criteria column. If you are able to take a look through them and provide feedback and address any potential bugs, please feel free to do so. Example: |
remove extra comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
performs additional checks within a function to ensure any calls to external packages fail are addressed. Stops the function and returns an error message if this occurs.
Create runAllValidations to run all current validation functions at once.
Pull Request Checklist (convert PR to draft if in progress)
Update your branch from the latest
mainand resolve any merge conflictsRun devtools::test(), devtools::check(), and devtools::document() locally; ensure tests pass and fix any errors, warnings, or notes. Add new dependencies to
DESCRIPTIONand document appropriatelyRequest review from at least one developer team member (convert PR to ready for review if it was designated as in progress)
Include a summary of the changes made and relevant context/motivation
Link issues to auto-close on merge (use Development sidebar or include "Closes #" in the PR)
Refresh inline/block comments for clarity
Review the bot's coverage report and add/update tests in
tests/testthatIf there is a bot spelling comment, run spelling::spell_check_package() locally and fix any misspellings; add approved project terms to WORDLIST with spelling::update_wordlist()