Skip to content

Validation function updates#28

Open
wokenny13 wants to merge 11 commits into
mainfrom
validation-function-updates
Open

Validation function updates#28
wokenny13 wants to merge 11 commits into
mainfrom
validation-function-updates

Conversation

@wokenny13
Copy link
Copy Markdown
Collaborator

performs additional checks within a function to ensure any calls to external packages fail are addressed. Stops the function and returns an error message if this occurs.

Create runAllValidations to run all current validation functions at once.

Pull Request Checklist (convert PR to draft if in progress)

  • Update your branch from the latest main and resolve any merge conflicts

  • Run devtools::test(), devtools::check(), and devtools::document() locally; ensure tests pass and fix any errors, warnings, or notes. Add new dependencies to DESCRIPTION and document appropriately

  • Request review from at least one developer team member (convert PR to ready for review if it was designated as in progress)

  • Include a summary of the changes made and relevant context/motivation

  • Link issues to auto-close on merge (use Development sidebar or include "Closes #" in the PR)

  • Refresh inline/block comments for clarity

  • Review the bot's coverage report and add/update tests in tests/testthat

  • If there is a bot spelling comment, run spelling::spell_check_package() locally and fix any misspellings; add approved project terms to WORDLIST with spelling::update_wordlist()

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 18, 2026

coverage-report

File Coverage Missing
All files 86%
R/loadNewData.R 88% 16 20 25 79 111 115 120 136 142 180 211 215 220 233 239 279 294 298 303 316 322 362 388 392 397 413 419 460 488 492 497 545 574 578 583 639 666 670 675 734 761 765 870-878 920 925 942-946 957-960 998

Minimum allowed coverage is 20%

Generated by 🐒 cobertura-action against 11d0398

@github-actions
Copy link
Copy Markdown

Spelling check failed. Details:

Spelling check failed. Found 1 potential misspelling(s). Note: Run spelling::spell_check_package() locally and fix any misspellings; add approved project terms to WORDLIST with spelling::update_wordlist().

  WORD         FOUND IN
validators   runAllValidations.Rd:22

@wokenny13 wokenny13 linked an issue May 22, 2026 that may be closed by this pull request
@wokenny13
Copy link
Copy Markdown
Collaborator Author

wokenny13 commented May 22, 2026

@ferribyh I made some updates to the validation functions in the TADACommunityHub as well as created a function to run all current existing validation functions for reviewing the allowable values within each criteria column. If you are able to take a look through them and provide feedback and address any potential bugs, please feel free to do so.

Example:

montana_criteria_crosswalk <- read_excel("inst/extdata/montana_criteria_crosswalk.xlsx")
# runs all validation functions
review2 <- runAllValidations(montana_criteria_crosswalk)
# identifies if any issues exist
message(review2$overall_status)
# summary of column validations
review2$summary

@wokenny13 wokenny13 requested a review from hillarymarler May 22, 2026 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Warning: Error in if: missing value where TRUE/FALSE needed

1 participant