feat: Use pull mode generator for search and chain. - #110
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the DDSS “search” and “chain” loops to use a pull-based generator/iterator style rather than a callback-based execute(handler) style, simplifying control flow in both the TypeScript and Python implementations.
Changes:
- Replace callback-based
execute(handler)usage with direct iteration (for ... of/for ... in) overSearchandChain. - Remove task aggregation (
Promise.all/asyncio.gather) in favor of awaiting inserts inline. - Keep the per-tick yielding behavior (
setTimeout(0)/asyncio.sleep(0)) after processing.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| ddss/search.ts | Switches search rule processing to iterator-based loop and performs inserts inline. |
| ddss/search.py | Switches search rule processing to iterator-based loop and performs inserts inline. |
| ddss/chain.ts | Switches chain rule processing to iterator-based loop and performs inserts inline. |
| ddss/chain.py | Switches chain rule processing to iterator-based loop and performs inserts inline. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
+21
to
+23
| for (const rule of search) { | ||
| const ds = rule.toString(); | ||
| tasks.push(insertOrIgnore(Fact, ds)); | ||
| await insertOrIgnore(Fact, ds); |
Comment on lines
+21
to
27
| for (const rule of search) { | ||
| const ds = rule.toString(); | ||
| tasks.push(insertOrIgnore(Fact, ds)); | ||
| await insertOrIgnore(Fact, ds); | ||
| const idea = strRuleGetStrIdea(ds); | ||
| if (idea) { | ||
| tasks.push(insertOrIgnore(Idea, idea)); | ||
| await insertOrIgnore(Idea, idea); | ||
| } |
Comment on lines
+21
to
+25
| for (const rule of chain) { | ||
| const ds = rule.toString(); | ||
| const idea = strRuleGetStrIdea(ds); | ||
| if (idea) { | ||
| tasks.push(insertOrIgnore(Idea, idea)); | ||
| await insertOrIgnore(Idea, idea); |
Comment on lines
+21
to
28
| for (const rule of chain) { | ||
| const ds = rule.toString(); | ||
| const idea = strRuleGetStrIdea(ds); | ||
| if (idea) { | ||
| tasks.push(insertOrIgnore(Idea, idea)); | ||
| await insertOrIgnore(Idea, idea); | ||
| } else { | ||
| tasks.push(insertOrIgnore(Fact, ds)); | ||
| await insertOrIgnore(Fact, ds); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.