chore: Fix typing annotation in ddss.py. - #111
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR focuses on small readability and typing improvements across the DDSS Python components (CLI wiring, ORM insert helpers, and e-graph utilities).
Changes:
- Renames loop variables in
egg/outputto clearer names (idea,fact). - Adds/adjusts type annotations in the CLI (
component_map, coroutine list) and prompt input. - Makes return values explicit (
return None) and adds an explicit__init__return type in the e-graph module.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| ddss/output.py | Readability-only variable renames in DB polling loop. |
| ddss/orm.py | Adds dialect-specific Insert type annotations for insert-or-ignore statements. |
| ddss/main.py | Refines component map typing and annotates coroutine list creation. |
| ddss/input.py | Adds an explicit type annotation for the PromptSession instance. |
| ddss/egraph.py | Makes None returns explicit and annotates _EGraph.__init__. |
| ddss/egg.py | Readability-only variable renames in DB polling loop. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
| if not isinstance(term, List): | ||
| return | ||
| return None | ||
| if not (len(term) == 4 or str(term[0]) == "binary" or str(term[1]) == "=="): |
| from .chain import main as chain | ||
|
|
||
| component_map: dict[str, callable[[async_sessionmaker[AsyncSession]], Awaitable[None]]] = { | ||
| component_map: dict[str, Callable[[async_sessionmaker[AsyncSession]], Coroutine[None, None, None]]] = { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.