Skip to content

fix: Remove unused imports and superfluous arguments in tests - #119

Merged
hzhangxyz merged 1 commit into
mainfrom
dev/superfluous-trailing-arguments
Apr 6, 2026
Merged

fix: Remove unused imports and superfluous arguments in tests#119
hzhangxyz merged 1 commit into
mainfrom
dev/superfluous-trailing-arguments

Conversation

@hzhangxyz

Copy link
Copy Markdown
Member
  • test_chain.ts: Remove unused Idea import
  • test_dump.ts: Remove superfluous addr argument from main() calls

- test_chain.ts: Remove unused Idea import
- test_dump.ts: Remove superfluous addr argument from main() calls
Copilot AI review requested due to automatic review settings April 6, 2026 10:41

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR cleans up the TypeScript test suite by removing unused imports and eliminating unnecessary arguments when calling main() in dump-related tests.

Changes:

  • Update tests/test_dump.ts to call main(sequelize) instead of passing an extra unused addr argument.
  • Remove the unused Idea import from tests/test_chain.ts.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
tests/test_dump.ts Removes a superfluous argument from main() calls to match the current ddss/dump.ts signature.
tests/test_chain.ts Removes an unused ORM import to avoid dead code in the test file.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@hzhangxyz
hzhangxyz merged commit 624bcc5 into main Apr 6, 2026
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants