fix: Remove unused imports and superfluous arguments in tests - #119
Merged
Conversation
hzhangxyz
commented
Apr 6, 2026
Member
- test_chain.ts: Remove unused Idea import
- test_dump.ts: Remove superfluous addr argument from main() calls
- test_chain.ts: Remove unused Idea import - test_dump.ts: Remove superfluous addr argument from main() calls
Contributor
There was a problem hiding this comment.
Pull request overview
This PR cleans up the TypeScript test suite by removing unused imports and eliminating unnecessary arguments when calling main() in dump-related tests.
Changes:
- Update
tests/test_dump.tsto callmain(sequelize)instead of passing an extra unusedaddrargument. - Remove the unused
Ideaimport fromtests/test_chain.ts.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/test_dump.ts | Removes a superfluous argument from main() calls to match the current ddss/dump.ts signature. |
| tests/test_chain.ts | Removes an unused ORM import to avoid dead code in the test file. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.