Enhance test_egg_substitution_fx_xyz to cover symmetry, transitivity, congruence, and substitution - #30
Merged
Merged
Conversation
…metry, transitivity, congruence, and substitution Co-authored-by: hzhangxyz <11623447+hzhangxyz@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix egg test to include complex scenarios
Enhance test_egg_substitution_fx_xyz to cover symmetry, transitivity, congruence, and substitution
Dec 23, 2025
hzhangxyz
approved these changes
Dec 23, 2025
Member
|
@copilot 修一下pre commit的问题 |
Co-authored-by: hzhangxyz <11623447+hzhangxyz@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances the test_egg_substitution_fx_xyz test to comprehensively validate the integration of four core egraph equality rules (symmetry, transitivity, congruence, and substitution) rather than testing only a simple substitution chain.
- Replaced simple variable chain test (x=y, y=z, f(x) → f(z)) with an integrated scenario using a, b, c variables
- Added verification for symmetry (a=b → b=a), transitivity (a=b, b=c → a=c), congruence (b=c → f(b)=f(c)), and substitution (f(a), a=c → f(c))
- Enhanced test assertions from one to four, checking each egraph rule individually
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
hzhangxyz
approved these changes
Dec 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plan to Fix test_egg_substitution_fx_xyz
test_egg_substitution_fx_xyzto be more comprehensive by combining:Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.