ci: remove explicit 'latest' versions and unnecessary env vars in wor… - #67
Conversation
There was a problem hiding this comment.
Pull request overview
This PR simplifies CI workflows by removing unused configuration and explicit 'latest' version pins in GitHub Actions. The goal is to reduce unnecessary env vars and avoid non-deterministic version configuration in the pipelines.
Changes:
- Removed the unused
PYTHON_LATEST_VERSIONenvironment variable from the pytest workflow. - Dropped explicit
node-version: 'latest'from the npm publish workflow’sactions/setup-nodestep. - Dropped explicit
node-version: 'latest'from the docs build workflow’sactions/setup-nodestep.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
.github/workflows/pytest.yml |
Cleans up an unused global env var; Python versions are still controlled via the matrix. |
.github/workflows/npm.yml |
Removes node-version: 'latest' from actions/setup-node, but currently leaves the step without any Node version configured, which will break the workflow. |
.github/workflows/docs.yml |
Removes node-version: 'latest' from actions/setup-node, but similarly leaves the step without a configured Node version, which will break the workflow. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -25,7 +25,6 @@ jobs: | |||
|
|
|||
| - uses: actions/setup-node@v6 | |||
| with: | |||
There was a problem hiding this comment.
Removing the node-version: 'latest' line here leaves actions/setup-node@v6 without any node-version or node-version-file input, which will cause the action to fail with "Input required and not supplied: node-version" at runtime. To keep the workflow working while avoiding latest, configure a specific Node version (e.g., an LTS range like 22.x) or point node-version-file at your .nvmrc/.node-version file instead of removing the version entirely.
| with: | |
| with: | |
| node-version: '22.x' |
| @@ -20,7 +20,6 @@ jobs: | |||
|
|
|||
| - uses: actions/setup-node@v6 | |||
| with: | |||
There was a problem hiding this comment.
By removing node-version: 'latest' here, this actions/setup-node@v6 step no longer supplies a node-version or node-version-file, so the action will fail with a missing required input. To keep builds deterministic and functional, specify a pinned Node version (for example an LTS range like 22.x) or use node-version-file referencing your repo's Node version file instead of omitting the version entirely.
| with: | |
| with: | |
| node-version: '22.x' |
…kflows