Skip to content

Remove version exports from Python packages for consistency with TypeScript #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hzhangxyz merged 2 commits into from
Dec 20, 2025
Merged

Remove version exports from Python packages for consistency with TypeScript #130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
56d0530
Initial plan
Copilot Dec 20, 2025
efbabd8
Remove version exports from Python packages
Copilot Dec 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apyds/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
_version.py

Copilot AI Dec 20, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This .gitignore file is now effectively empty after removing the _version.py entry. Consider removing this file entirely as an empty .gitignore serves no purpose and can be confusing for maintainers.

Suggested change
# This .gitignore file is intentionally kept without any ignore patterns.
# It documents that the apyds directory does not currently require
# directory-specific ignore rules. Add patterns here in the future if needed.

Copilot uses AI. Check for mistakes.
2 changes: 0 additions & 2 deletions apyds/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
"Term",
"Rule",
"Search",
"__version__",
]

from .buffer_size import buffer_size, scoped_buffer_size
Expand All @@ -24,4 +23,3 @@
from .term_t import Term
from .rule_t import Rule
from .search_t import Search
from .version import __version__
14 changes: 0 additions & 14 deletions apyds/version.py
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion bnf/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ license = "AGPL-3.0-or-later"
Repository = "https://github.com/USTC-KnowledgeComputingLab/ds.git"

[tool.setuptools_scm]
version_file = "apyds_bnf/_version.py"
version_scheme = "no-guess-dev"
fallback_version = "0.0.0"
root = ".."
Expand Down
1 change: 0 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ license = "AGPL-3.0-or-later"
Repository = "https://github.com/USTC-KnowledgeComputingLab/ds.git"

[tool.setuptools_scm]
version_file = "apyds/_version.py"
version_scheme = "no-guess-dev"
fallback_version = "0.0.0"

Expand Down