Skip to content

ci: remove explicit 'latest' version settings for Python and Node.js #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hzhangxyz merged 1 commit into from
Jan 28, 2026
Merged

ci: remove explicit 'latest' version settings for Python and Node.js #213

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/bnf-jest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@ jobs:

- uses: actions/setup-node@v6
with:

Copilot AI Jan 28, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the node-version specification makes the npm publishing step non-deterministic. Without an explicit version, actions/setup-node will use the runner's default Node.js version, which can change when GitHub updates their runners. This could lead to inconsistent builds or publishing failures if the default version changes. Consider specifying a version explicitly (e.g., '20' or '22') to ensure reproducible builds.

Suggested change
with:
with:
node-version: '22'

Copilot uses AI. Check for mistakes.
node-version: latest
cache: 'npm'

- name: version
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/bnf-pytest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ jobs:

- uses: astral-sh/setup-uv@v7
with:

Copilot AI Jan 28, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the python-version specification makes the build non-deterministic. Without an explicit version, astral-sh/setup-uv will use the system Python version, which can vary across runner updates. This could lead to inconsistent builds. Consider specifying a version explicitly (e.g., '3.11' or '3.12') or use a .python-version file to ensure reproducible builds.

Suggested change
with:
with:
python-version: '3.12'

Copilot uses AI. Check for mistakes.
python-version: latest
enable-cache: true

- name: build
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/docs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ jobs:

- uses: actions/setup-node@v6
with:

Copilot AI Jan 28, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the node-version specification makes the documentation build non-deterministic. Without an explicit version, actions/setup-node will use the runner's default Node.js version, which can change when GitHub updates their runners. This could lead to inconsistent documentation builds or build failures if the default version changes. Consider specifying a version explicitly (e.g., '20' or '22') to ensure reproducible builds.

Suggested change
with:
with:
node-version: '20'

Copilot uses AI. Check for mistakes.
node-version: 'latest'
cache: 'npm'

- uses: actions/cache@v5
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/egg-jest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ jobs:

- uses: actions/setup-node@v6
with:

Copilot AI Jan 28, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the node-version specification makes the npm publishing step non-deterministic. Without an explicit version, actions/setup-node will use the runner's default Node.js version, which can change when GitHub updates their runners. This could lead to inconsistent builds or publishing failures if the default version changes. Consider specifying a version explicitly (e.g., '20' or '22') to ensure reproducible builds.

Suggested change
with:
with:
node-version: '20'

Copilot uses AI. Check for mistakes.
node-version: latest
cache: 'npm'

- name: version
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/egg-pytest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ jobs:

- uses: astral-sh/setup-uv@v7
with:

Copilot AI Jan 28, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the python-version specification makes the build non-deterministic. Without an explicit version, astral-sh/setup-uv will use the system Python version, which can vary across runner updates. This could lead to inconsistent builds. Consider specifying a version explicitly (e.g., '3.11' or '3.12') or use a .python-version file to ensure reproducible builds.

Suggested change
with:
with:
python-version: '3.12'

Copilot uses AI. Check for mistakes.
python-version: latest
enable-cache: true

- name: build
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/jest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ jobs:

- uses: actions/setup-node@v6
with:

Copilot AI Jan 28, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the node-version specification makes the npm publishing step non-deterministic. Without an explicit version, actions/setup-node will use the runner's default Node.js version, which can change when GitHub updates their runners. This could lead to inconsistent builds or publishing failures if the default version changes. Consider specifying a version explicitly (e.g., '20' or '22') to ensure reproducible builds.

Suggested change
with:
with:
node-version: '22'

Copilot uses AI. Check for mistakes.
node-version: latest
cache: 'npm'

- uses: actions/cache@v5
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/pytest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ jobs:

- uses: actions/setup-python@v6
with:

Copilot AI Jan 28, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the python-version specification makes the build non-deterministic. Without an explicit version, actions/setup-python will use whatever Python version is pre-installed on the runner, which can vary across different runner images and change over time when GitHub updates their runners. This could lead to inconsistent builds and potential compatibility issues with cibuildwheel. Consider specifying a version explicitly (e.g., '3.11' or '3.12') or use a .python-version file to ensure reproducible builds.

Suggested change
with:
with:
python-version: '3.12'

Copilot uses AI. Check for mistakes.
python-version: latest
cache: 'pip'

- name: install cibuildwheel
Expand Down Expand Up @@ -76,7 +75,6 @@ jobs:

- uses: astral-sh/setup-uv@v7
with:

Copilot AI Jan 28, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the python-version specification makes the build non-deterministic. Without an explicit version, astral-sh/setup-uv will use the system Python version, which can vary across runner updates. This could lead to inconsistent source distribution builds. Consider specifying a version explicitly (e.g., '3.11' or '3.12') or use a .python-version file to ensure reproducible builds.

Suggested change
with:
with:
python-version: '3.12'

Copilot uses AI. Check for mistakes.
python-version: latest
enable-cache: true

- name: build sdist
Expand Down