ci: specify latest Node.js and Python versions in workflows - #215
Merged
Conversation
Explicitly define and use NODE_LATEST_VERSION ('24') and PYTHON_LATEST_VERSION ('3.14') across GitHub Action workflows to ensure consistent environments for Jest and Pytest.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR standardizes Node.js and Python versions across GitHub Action workflows by introducing environment variables NODE_LATEST_VERSION ('24') and PYTHON_LATEST_VERSION ('3.14'). These versions align with the repository's .node-version and .python-version files and are already used in the test matrices.
Changes:
- Added
NODE_LATEST_VERSION: '24'environment variable to Jest workflows and applied it to Node.js setup in build/publish jobs - Added
PYTHON_LATEST_VERSION: '3.14'environment variable to Pytest workflows and applied it to Python setup in build/publish jobs - Updated emsdk cache key in jest.yml to include the Node version for consistency
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/pytest.yml | Added PYTHON_LATEST_VERSION env var and applied it to Python setup in wheels and sdist jobs |
| .github/workflows/jest.yml | Added NODE_LATEST_VERSION env var, applied it to Node.js setup in npm job, and updated cache key |
| .github/workflows/egg-pytest.yml | Added PYTHON_LATEST_VERSION env var and applied it to Python setup in build job |
| .github/workflows/egg-jest.yml | Added NODE_LATEST_VERSION env var and applied it to Node.js setup in npm job |
| .github/workflows/bnf-pytest.yml | Added PYTHON_LATEST_VERSION env var and applied it to Python setup in build job |
| .github/workflows/bnf-jest.yml | Added NODE_LATEST_VERSION env var and applied it to Node.js setup in npm job |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explicitly define and use NODE_LATEST_VERSION ('24') and PYTHON_LATEST_VERSION ('3.14') across GitHub Action workflows to ensure consistent environments for Jest and Pytest.