Skip to content

Fix README inaccuracies in prerequisites and build order - #26

Merged
hzhangxyz merged 2 commits into
mainfrom
copilot/update-readme-prerequisites
Nov 25, 2025
Merged

Fix README inaccuracies in prerequisites and build order#26
hzhangxyz merged 2 commits into
mainfrom
copilot/update-readme-prerequisites

Conversation

Copilot AI commented Nov 25, 2025

Copy link
Copy Markdown
Contributor

README had incorrect prerequisite groupings and inconsistent ordering between build and test sections.

Changes

  • Prerequisites: Reorganized by language target

    • TypeScript: Only Emscripten SDK (no CMake/compiler needed)
    • Python: Python 3.10-3.14, C++20 compiler, CMake 3.30+
    • C++: C++20 compiler, CMake 3.30+
    • Removed scikit-build-core and pybind11 (auto-installed via pip install)
  • Build order: Reordered to TypeScript → Python → C++ to match Running Tests section

Original prompt

This section details on the original issue you should resolve

<issue_title>readme有些不准确的地方</issue_title>
<issue_description>Prerequisites

C++20 compatible compiler
CMake 3.30+
For TypeScript: Emscripten SDK
For Python: Python 3.10-3.14, scikit-build-core, pybind11

这个地方,cmake和c++20 compiler是python和c++需要的,ts会直接用emscripten。另外python那里不需要写pybind11和scikit build core,这个会在python -m build或者pip install .的时候自动安装。

下面的 Running Tests 顺序和上面的build顺序不一致,统一按照ts, python, cxx的顺序来吧。</issue_description>

Comments on the Issue (you are @copilot in this section)


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: hzhangxyz <11623447+hzhangxyz@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix inaccuracies in README prerequisites section Fix README inaccuracies in prerequisites and build order Nov 25, 2025
Copilot AI requested a review from hzhangxyz November 25, 2025 01:15
@hzhangxyz
hzhangxyz marked this pull request as ready for review November 25, 2025 01:18
@hzhangxyz
hzhangxyz merged commit 42719d9 into main Nov 25, 2025
64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

readme有些不准确的地方

2 participants