fix: Fix the return number of function execute of chain.

[hzhangxyz]

No description provided.

[Copilot]

Pull request overview

This PR adjusts Chain.execute()’s returned count to reflect all newly inferred results during execution, aligning behavior across the C++ core and the Python/JS/C++ test suites.

Changes:

• Update ds::chain_t::execute() to return the combined number of inferred intermediate rules and inferred facts.
• Update Chain tests in Python, JS, and C++ to assert the corrected return values.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File	Description
src/chain.cc	Fixes execute() return value to include both temp_rules and temp_facts.
tests/test_chain.py	Updates expected counts for Chain.execute() in Python tests.
tests/test_chain.mjs	Updates expected counts for Chain.execute() in JS tests.
tests/test_chain.cc	Updates expected counts for chain_t::execute() in C++ tests.

Comments suppressed due to low confidence (1)

src/chain.cc:135

• execute() inserts newly inferred facts into facts with current_cycle, but it never updates last_fact_cycle. Because the rule-skip condition earlier uses last_fact_cycle <= done_cycle, subsequent execute() calls can incorrectly skip processing even when this call inferred new facts (breaking multi-step inference across rules). Update last_fact_cycle when new facts are added here (e.g., set it to current_cycle if temp_facts is non-empty).

        for (auto it = temp_facts.begin(); it != temp_facts.end();) {
            auto node = temp_facts.extract(it++);
            facts.emplace(std::move(node.value()), current_cycle);
        }
        return count;

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.