fix: Fix a potential bug in ds.cc. - #276
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates language binding iterators (Python via pybind11 and TypeScript/JS via embind) to use the generator’s end sentinel when detecting exhaustion.
Changes:
- Replace
*iterator == nullptrwith*iterator == generator.end()inIterator::next()for both bindings.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| atsds/ds.cc | Use generator.end() sentinel for JS/TS binding iterator exhaustion check. |
| apyds/ds.cc | Use generator.end() sentinel for Python binding iterator exhaustion check. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
13
to
21
| ds::rule_t* next() { | ||
| if (initialized) { | ||
| ++*iterator; | ||
| } else { | ||
| iterator = std::make_unique<iterator_t>(generator.begin()); | ||
| initialized = true; | ||
| } | ||
| if (*iterator == nullptr) { | ||
| if (*iterator == generator.end()) { | ||
| return nullptr; |
Comment on lines
14
to
22
| ds::rule_t* next() { | ||
| if (initialized) { | ||
| ++*iterator; | ||
| } else { | ||
| iterator = std::make_unique<iterator_t>(generator.begin()); | ||
| initialized = true; | ||
| } | ||
| if (*iterator == nullptr) { | ||
| if (*iterator == generator.end()) { | ||
| return nullptr; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.