chore: update ds::generator for better code quality in generator.hh. - #277
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the internal ds::generator implementation in include/ds/generator.hh, restructuring it around nested promise_type / iterator_type to simplify the coroutine wiring and iteration API.
Changes:
- Replaces the separate
_generator_promise<T>type with a nested_generator<T>::promise_type. - Reworks iteration to use an explicit
iterator_type end()sentinel instead ofnullptr_t. - Removes the
std::coroutine_traitsspecialization previously used to bind_generatorto its promise type.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
+8
to
13
| struct _generator { | ||
| struct promise_type; | ||
| struct iterator_type; | ||
| using handle_type = std::coroutine_handle<promise_type>; | ||
| handle_type handle_; | ||
|
|
Comment on lines
+16
to
20
| _generator(_generator&& other) : handle_(other.handle_) { | ||
| other.handle_ = nullptr; | ||
| } | ||
| _generator& operator=(_generator&& other) noexcept { | ||
| _generator& operator=(_generator&& other) { | ||
| if (this != &other) { |
Comment on lines
+61
to
+63
| std::suspend_always yield_value(T value) { | ||
| value_ = value; | ||
| return {}; |
Comment on lines
+65
to
+67
| void unhandled_exception() { | ||
| throw; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.