Skip to content

Fix dev container creation by switching to working feature sources #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hzhangxyz merged 3 commits into from
Nov 28, 2025
Merged

Fix dev container creation by switching to working feature sources #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
84bb00a
Initial plan
Copilot Nov 28, 2025
ef6987c
Fix dev container creation by updating features and base image
Copilot Nov 28, 2025
13d167c
Add version: latest for uv and emscripten features for consistency
Copilot Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions .devcontainer/devcontainer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,21 @@
{
"name": "DS Development Container",
"image": "mcr.microsoft.com/devcontainers/base:ubuntu",
"image": "mcr.microsoft.com/devcontainers/base:debian",
"features": {
"ghcr.io/devcontainers/features/cmake:1": {
"ghcr.io/devcontainers-extra/features/cmake:1": {
"version": "latest"
},
"ghcr.io/devcontainers/features/python:1": {
"version": "latest"
},
"ghcr.io/devcontainers/features/node:1": {
"version": "latest"
},
"ghcr.io/gvatsal60/dev-container-features/uv:0": {
"version": "latest"
},
"ghcr.io/ebaskoro/devcontainer-features/emscripten:1": {
"version": "latest"
}
},
"postCreateCommand": ".devcontainer/post-create.sh",
Expand Down
25 changes: 1 addition & 24 deletions .devcontainer/post-create.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,34 +5,11 @@ set -euo pipefail
sudo apt-get update
sudo apt-get install -y libgtest-dev clang-format

# Install uv (Python package manager)
curl -LsSf https://astral.sh/uv/install.sh | sh

# Add uv to PATH for this script and future sessions
export PATH="$HOME/.local/bin:$PATH"
echo 'export PATH="$HOME/.local/bin:$PATH"' >> "$HOME/.bashrc"

# Install Python dependencies
# Install Python dependencies (uv is installed via devcontainer feature)
uv sync --locked --extra dev

# Install Node.js dependencies
npm ci

# Install emscripten to a persistent location
EMSDK_DIR="$HOME/emsdk"
if [ ! -d "$EMSDK_DIR" ]; then
git clone https://github.com/emscripten-core/emsdk.git "$EMSDK_DIR"
else
git -C "$EMSDK_DIR" pull
fi
(
cd "$EMSDK_DIR"
./emsdk install latest
./emsdk activate latest
)

# Add emsdk to shell config for future sessions
echo "source $EMSDK_DIR/emsdk_env.sh" >> "$HOME/.bashrc"

# Install pre-commit hooks
uv run pre-commit install