Conversation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds search functionality to the core library, enabling automated theorem proving and rule-based inference across C++, Python, and JavaScript implementations. The search functionality allows users to add rules and facts, then execute inference searches with customizable callbacks.
Key changes:
- Implemented a complete search system with cycle-based inference tracking
- Added bindings for all three target languages (C++, Python, JavaScript)
- Updated example files to demonstrate the new search API instead of manual rule matching
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| include/ds/search.hh | Header file defining the search_t class interface and documentation |
| src/search.cc | Core C++ implementation of the search functionality with rule/fact management |
| tsds/ds.cc | JavaScript/Emscripten bindings for the search class |
| tsds/tsds.mts | TypeScript wrapper class providing a clean API for search functionality |
| pyds/ds.cc | Python/pybind11 bindings for the search class |
| pyds/search_t.py | Python wrapper class with type hints and clean interface |
| pyds/init.py | Export the Search class in the Python module |
| package.json | Updated emcc command to use C++20 standard |
| examples/. | Updated example files to use the new search API |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO