Compile embind to single file without source maps - #85
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Added -s SINGLE_FILE=1 to emcc command - Removed -gsource-map=inline from emcc command - Removed source map files from package.json files array - Disabled sourcemap in rollup.config.mjs - Removed ds.wasm.map from copy patterns Co-authored-by: hzhangxyz <11623447+hzhangxyz@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Compile embind to a single file and remove source map
Compile embind to single file without source maps
Dec 9, 2025
Member
|
@copilot ds.wasm 不再生成了, 需要去掉. copy这个plugin不需要了, 需要去掉. sourcemap: false是默认行为, 直接去掉就行. |
…urcemap config - Removed dist/ds.wasm from files array (no longer generated with SINGLE_FILE=1) - Removed copy plugin and its import (no longer needed) - Removed sourcemap: false (default behavior) Co-authored-by: hzhangxyz <11623447+hzhangxyz@users.noreply.github.com>
Contributor
Author
Member
|
package.json 中 的 @web/rollup-plugin-copy 要删掉. @copilot |
- Removed unused @web/rollup-plugin-copy package - Applied biome formatting fixes Co-authored-by: hzhangxyz <11623447+hzhangxyz@users.noreply.github.com>
Contributor
Author
hzhangxyz
approved these changes
Dec 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plan: Compile embind to a single file and skip generating source map
-s SINGLE_FILE=1to emcc command-gsource-map=inlinefrom emcc command in package.jsonChanges Made
package.json
-s SINGLE_FILE=1to the emcc command to compile to a single file-gsource-map=inlineflag from emcc commanddist/ds.wasmfrom files array since it's embedded in the JS file with SINGLE_FILE=1@web/rollup-plugin-copyfrom devDependencies (no longer used)rollup.config.mjs
sourcemap: falsesince it's the default behaviorOriginal prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.