Skip to content

Test/add test for arithmetic - #41

Merged
hzhangxyz merged 9 commits into
mainfrom
test/add-test-for-arithmetic
Aug 10, 2025
Merged

Test/add test for arithmetic#41
hzhangxyz merged 9 commits into
mainfrom
test/add-test-for-arithmetic

Conversation

@gausshj

@gausshj gausshj commented Aug 8, 2025

Copy link
Copy Markdown
Collaborator

Add test for arithmetic.
Related to #22

@codecov

codecov Bot commented Aug 8, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 72.72727% with 6 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
grassmann_tensor/tensor.py 72.72% 6 Missing ⚠️

📢 Thoughts on this report? Let us know!

@hzhangxyz
hzhangxyz force-pushed the test/add-test-for-arithmetic branch from abf1240 to 6adb970 Compare August 8, 2025 08:32
@hzhangxyz

Copy link
Copy Markdown
Member

@gausshj 做的很好。接下来,请在我修改后的基础上,使用pytest.raises确保和不可以相互加减乘除的对象进行操作时,能够正确的raise error。你的目标是: https://app.codecov.io/gh/USTC-KnowledgeComputingLab/grassmann-tensor/pull/41/indirect-changes 这个页面中每个运算的4个判断都被覆盖。

@hzhangxyz

Copy link
Copy Markdown
Member

哦对,不用close这个PR,直接在这个PR里继续push就行了。

@gausshj

gausshj commented Aug 8, 2025 via email

Copy link
Copy Markdown
Collaborator Author

@hzhangxyz

Copy link
Copy Markdown
Member

我先前没意识到,为了进行算术操作的测试,你应该需要clone 函数,我在 (#43) 中添加了。

@hzhangxyz
hzhangxyz merged commit ca46c55 into main Aug 10, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants