Add support for trivial edges in reshape function - #64
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
hzhangxyz
force-pushed
the
dev/add-one-dimensional-edge-in-reshape
branch
from
August 31, 2025 04:14
44d1d46 to
ad95164
Compare
hzhangxyz
force-pushed
the
dev/add-one-dimensional-edge-in-reshape
branch
from
August 31, 2025 04:15
ad95164 to
f9535e0
Compare
Closed
13 tasks
gausshj
reviewed
Sep 1, 2025
| merging = True | ||
| if total < self.tensor.shape[cursor_self]: | ||
| merging = False | ||
| if merging: |
Member
Author
There was a problem hiding this comment.
这里主要是因为，前后edge不一样大的话，我可以很轻松判断是在merging还是splitting，但是相等的时候比较麻烦。但是我也不能直接无脑认为没有任何变化，比如 (1, 3), (0, 1) <-> (3, 1) 这种情况，正向是merging，反向是splitting。所以我先检查了是否前后两个边真的一样，如果一样直接先处理了，处理后直接continue，如果不是的话，我预期应该是这种喊 (0, 1) 的情况，用前面那个while循环在self中检查后面是否有(0, 1) 边有的话就merging，没有的话就splitting。如果我的预期是错的，用户输入不合法，他无论走merging还是splitting后面都会报错。
hzhangxyz
force-pushed
the
dev/add-one-dimensional-edge-in-reshape
branch
from
September 2, 2025 02:40
f3ba170 to
aab9668
Compare
This reverts commit 0189161.
…anch' into dev/add-one-dimensional-edge-in-reshape
msg-bq
reviewed
Sep 2, 2025
|
咦晚了一步哈哈哈哈 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.