Add assertion tests for matmul of impure tensors - #69
Merged
Conversation
gausshj
commented
Sep 12, 2025
gausshj
commented
Collaborator
- Add assertion tests for matmul of impure tensors
hzhangxyz
requested changes
Sep 29, 2025
hzhangxyz
left a comment
hzhangxyz
left a comment
Member
There was a problem hiding this comment.
这个pr整体没啥毛病，impure even的参数少点吧，broadcast, x, impure even是乘起来的数目，很大了。
| torch.randn([*[x + impure_even for x in broadcast_b], dim_common, dim_b]), | ||
| ).update_mask() | ||
| if a.tensor.dim() <= 2 and b.tensor.dim() <= 2: | ||
| pytest.skip("One of the two tensors needs to have a dimension greater than 2") |
Collaborator
Author
There was a problem hiding this comment.
因为后面判断了AssertionError：“All edges except the last two must be pure even”，所以张量围度必须大于2。
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
13 tasks
- Add assertion tests for matmul of impure tensors Signed-off-by: Gausshj <kylin_0@qq.com> Signed-off-by: Hao Zhang <hzhangxyz@outlook.com>
hzhangxyz
previously approved these changes
Oct 9, 2025
hzhangxyz
force-pushed
the
test/add-more-test-for-matmul
branch
from
October 9, 2025 11:14
05e3a47 to
7ded7f1
Compare
gausshj
changed the title
gausshj
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.