fix(reshape): support reshaping 1D Grassmann tensors to all-ones shapes - #73
Merged
Merged
Conversation
gausshj
commented
Oct 29, 2025
gausshj
commented
Collaborator
- Add support for reshaping 1D Grassmann tensors to all-ones shapes
- Add test cases for new feature
- Raising a clear AssertionError if non-trivial dims remain after self dims are exhausted.
- Add support for reshaping 1D Grassmann tensors to all-ones shapes - Add test cases for new feature - Raising a clear AssertionError if non-trivial dims remain after self dims are exhausted.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
hzhangxyz
reviewed
Oct 30, 2025
hzhangxyz
left a comment
hzhangxyz
left a comment
Member
There was a problem hiding this comment.
为什么要特殊处理 (1, ) 这个情况? (1, 1, 1, 1), (1, 1, 1) 这些不应该和他是类似的么?
| return GrassmannTensor(_arrow=(), _edges=(), _tensor=tensor) | ||
|
|
||
| if new_shape == (1,) and int(self.tensor.numel()) == 1: | ||
| eo = self._calculate_even_odd() |
Member
There was a problem hiding this comment.
为什么要特殊处理 (1, ) 这个情况? (1, 1, 1, 1), (1, 1, 1) 这些不应该和他是类似的么?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.