Skip to content

Add support for exponential - #75

Merged
gausshj merged 1 commit into
feature/simple-updatefrom
dev/add-support-for-exponential
Nov 3, 2025
Merged

Add support for exponential#75
gausshj merged 1 commit into
feature/simple-updatefrom
dev/add-support-for-exponential

Conversation

@gausshj

@gausshj gausshj commented Nov 3, 2025

Copy link
Copy Markdown
Collaborator
  • Add support for exponential
  • Add test cases for exponential

@codecov

codecov Bot commented Nov 3, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Comment thread grassmann_tensor/tensor.py Outdated
_tensor=tensor,
)

def _group_legs(

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个平时确实会叫legs/edge/index/..., 他们都是同一个东西, 不过这个库里之前都是称呼edge的, 就统一用edge这个名字吧

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好的,已经在29ef0ad中做了修改。

Comment thread grassmann_tensor/tensor.py Outdated

tensor_exp = dataclasses.replace(tensor, _tensor=tensor_exp)

if axes_to_reverse:

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

别用axes, 前面的legs, axes都是同一个东西, 用同一个名字吧.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好的,已经在29ef0ad中做了修改。

Comment thread grassmann_tensor/tensor.py Outdated
edges_after_permute = tuple(self.edges[i] for i in order)
tensor_exp = tensor_exp.reshape(edges_after_permute)

inv = [0] * self.tensor.dim()

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个地方后面应该会经常使用, 可以单独变成一个函数. 另外, 变量名尽量写全点吧.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好的,已经在4d8b40e中做了修改。

- Add support for exponential
- Add test cases for exponential
@gausshj
gausshj force-pushed the dev/add-support-for-exponential branch from 4d8b40e to f55d7f4 Compare November 3, 2025 07:52
@gausshj
gausshj merged commit c511401 into feature/simple-update Nov 3, 2025
31 checks passed
@gausshj gausshj changed the title dev(exponential): add support for exponential Add support for exponential Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants