Skip to content

Refactor get inverse order method #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gausshj merged 1 commit into from
Nov 21, 2025
Merged

Refactor get inverse order method #84

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions grassmann_tensor/tensor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -777,15 +777,12 @@ def svd(
return U, S, Vh

@staticmethod
def get_inv_order(dim: int, order: tuple[int, ...]) -> tuple[int, ...]:
inv = [0] * dim
def get_inv_order(order: tuple[int, ...]) -> tuple[int, ...]:
inv = [0] * len(order)
for new_position, origin_idx in enumerate(order):
inv[origin_idx] = new_position
return tuple(inv)

def _get_inv_order(self, order: tuple[int, ...]) -> tuple[int, ...]:
return self.get_inv_order(self.tensor.dim(), order)

def contract(
self,
b: GrassmannTensor,
Expand Down Expand Up @@ -925,7 +922,7 @@ def exponential(self, pairs: tuple[tuple[int, ...], tuple[int, ...]]) -> Grassma
edges_after_permute = tuple(self.edges[i] for i in order)
tensor_exp = tensor_exp.reshape(edges_after_permute)

inv_order = self._get_inv_order(order)
inv_order = self.get_inv_order(order)

tensor_exp = tensor_exp.permute(inv_order)

Expand Down Expand Up @@ -966,7 +963,7 @@ def identity(self, pairs: tuple[tuple[int, ...], tuple[int, ...]]) -> GrassmannT
edges_after_permute = tuple(self.edges[i] for i in order)
tensor_identity = tensor_identity.reshape(edges_after_permute)

inv_order = self._get_inv_order(order)
inv_order = self.get_inv_order(order)

tensor_identity = tensor_identity.permute(inv_order)

Expand Down
2 changes: 1 addition & 1 deletion tests/exponential_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ def test_exponential_via_taylor_expansion(
order = left_legs + right_legs
edges_after_permute = tuple(tensor.edges[i] for i in order)
tensor_taylor_expansion = tensor_taylor_expansion.reshape(edges_after_permute)
inv_order = tensor._get_inv_order(order)
inv_order = tensor.get_inv_order(order)
tensor_taylor_expansion = tensor_taylor_expansion.permute(inv_order)

assert torch.allclose(tensor_taylor_expansion.tensor, tensor_exp.tensor)
2 changes: 1 addition & 1 deletion tests/svd_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ def test_svd(

left_legs, right_legs = gt.get_legs_pair(len(edges), free_names_u)
order = left_legs + right_legs
inv_order = gt.get_inv_order(USV.tensor.dim(), order)
inv_order = gt.get_inv_order(order)
USV = USV.permute(inv_order)

masked = gt.update_mask().tensor
Expand Down