Skip to content

Remove obsolete tests references from CONTRIBUTING.md - #136

Merged
hzhangxyz merged 3 commits into
mainfrom
copilot/remove-tests-folder-reference
Dec 18, 2025
Merged

Remove obsolete tests references from CONTRIBUTING.md#136
hzhangxyz merged 3 commits into
mainfrom
copilot/remove-tests-folder-reference

Conversation

Copilot AI commented Dec 18, 2025

Copy link
Copy Markdown
Contributor

The tests folder has been removed from the repository, but CONTRIBUTING.md still referenced it in multiple places.

Changes

  • Removed ", and the tests into the folder named tests" from the Code Structure section (line 15)
  • Line 15 now reads: "We organize the package code into the folder named qmp." instead of mentioning both qmp and tests folders
  • Removed "and add tests" from the contribution guidelines section (line 29)
  • Line 29 now reads: "If necessary, please update documentations for your changes." instead of mentioning both documentation and tests
Original prompt

This section details on the original issue you should resolve

<issue_title>"and the tests into the folder named tests" 应该从 contributing md中删除.</issue_title>
<issue_description>tests现在已经暂时移除.</issue_description>

Comments on the Issue (you are @copilot in this section)


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@hzhangxyz

Copy link
Copy Markdown
Member

如有需要,请更新相关文档并为你的修改添加测试。 这句话也要删掉 @copilot

Co-authored-by: hzhangxyz <11623447+hzhangxyz@users.noreply.github.com>
Copilot AI changed the title [WIP] Remove reference to tests folder from contributing MD Remove obsolete tests folder reference from CONTRIBUTING.md Dec 18, 2025
Copilot AI requested a review from hzhangxyz December 18, 2025 20:57
Comment thread CONTRIBUTING.md Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"If necessary, please update documentations and add tests for your changes." 这句话也删掉吧.

Co-authored-by: hzhangxyz <11623447+hzhangxyz@users.noreply.github.com>

Copilot AI commented Dec 18, 2025

Copy link
Copy Markdown
Contributor Author

如有需要,请更新相关文档并为你的修改添加测试。 这句话也要删掉 @copilot

Done. Removed "and add tests" from line 29. See commit eae9f13.

Copilot AI changed the title Remove obsolete tests folder reference from CONTRIBUTING.md Remove obsolete tests references from CONTRIBUTING.md Dec 18, 2025
Copilot AI requested a review from hzhangxyz December 18, 2025 21:00
@hzhangxyz
hzhangxyz marked this pull request as ready for review December 18, 2025 21:00
Copilot AI review requested due to automatic review settings December 18, 2025 21:00
@hzhangxyz
hzhangxyz merged commit ccd2c95 into main Dec 18, 2025
2 of 3 checks passed
Copilot AI requested a review from hzhangxyz December 18, 2025 21:01

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes obsolete references to the tests folder from CONTRIBUTING.md, as the tests folder has been removed from the repository.

  • Removed mention of tests folder from the Code Structure section
  • Removed "and add tests" from the contribution guidelines section

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread CONTRIBUTING.md
The comments in the code are expected to be enough for other developers to understand your code.
Please add docstrings to the code in NumPy style.
If necessary, please update documentations and add tests for your changes.
If necessary, please update documentations for your changes.

Copilot AI Dec 18, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The word "documentations" should be "documentation" (singular form). In English, "documentation" is typically used as an uncountable noun.

Suggested change
If necessary, please update documentations for your changes.
If necessary, please update documentation for your changes.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"and the tests into the folder named tests" 应该从 contributing md中删除.

3 participants