Add trivial MPS network with generate() and wire generate into NetworkProto - #195
Merged
Merged
Conversation
…tworks Co-authored-by: hzhangxyz <11623447+hzhangxyz@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add mps.py network with generate function
Add trivial MPS network with Mar 5, 2026
generate() and wire generate into NetworkProto
hzhangxyz
requested changes
Mar 5, 2026
hzhangxyz
left a comment
Member
There was a problem hiding this comment.
用 NotImplementedError. 另外, generate的注释中, 除非是新的那个返回值, 其他尽量保持和 generate_unique 字母级语言风格一致
…ate_unique Co-authored-by: hzhangxyz <11623447+hzhangxyz@users.noreply.github.com>
Contributor
Author
Done in 03984c1. Changed all |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
generatemethod toNetworkProtoinmodel_dict.pywith return typetuple[torch.Tensor, torch.Tensor, torch.Tensor, None]generatemethod (raisesNotImplementedError) to all 3 WaveFunction classes inmlp.pygeneratemethod (raisesNotImplementedError) to all 3 WaveFunction classes intransformers.pyqmp/networks/mps.pywithWaveFunctionclass:sites,physical_dim,virtual_dimforward(): compute MPS amplitude via tensor contraction with open boundary conditionsgenerate_unique(): raisesNotImplementedErrorgenerate(): autoregressive sampling returning(unique_configs, amplitudes, counts, None)NotImplementedError(notRuntimeError) in all generate stubsgeneratedocstring style withgenerate_uniqueacrossmodel_dict.pyandmps.pyOriginal prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.