Refactor: clean up type annotations in hamiltonian.py and update .git… - #204
Merged
Conversation
…ignore - Remove redundant typing import and local variable type hints in Hamiltonian class. - Add .vscode and clarify .venv path in .gitignore.
There was a problem hiding this comment.
Pull request overview
Refactors the Hamiltonian implementation to remove redundant/unused typing artifacts and updates repository ignore rules to better match local dev environment setup.
Changes:
- Removed an unused
typingimport and redundant local variable type annotations inHamiltonianmethods. - Updated
.gitignoreto ignore only a repo-root/.venvand to ignore/.vscode.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
qmp/hamiltonian/hamiltonian.py |
Removes unused typing import and local typing.Callable annotations without changing runtime behavior. |
.gitignore |
Adjusts venv ignore rule to repo-root and adds ignore for VS Code settings directory. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ignore