Add symmetry-free MPS network to Hubbard and Ising models - #212
Merged
Conversation
Co-authored-by: hzhangxyz <11623447+hzhangxyz@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add MPS network to Hubbard and Ising models
Add symmetry-free MPS network to Hubbard and Ising models
Mar 5, 2026
hzhangxyz
marked this pull request as ready for review
March 5, 2026 23:16
There was a problem hiding this comment.
Pull request overview
Wires the existing symmetry-free MPS network into the Hubbard and Ising model registries under the "mps" key.
Changes:
- Add
MpsConfig(withvirtual_dim) and register it asModel.network_dict["mps"]for Ising. - Add
MpsConfig(withvirtual_dim) and register it asModel.network_dict["mps"]for Hubbard. - Use
sites = m * n(Ising) vssites = m * n * 2(Hubbard, spin up/down orbitals).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| qmp/models/ising.py | Imports MPS wavefunction, adds MpsConfig, and registers "mps" network for Ising. |
| qmp/models/hubbard.py | Imports MPS wavefunction, adds MpsConfig, and registers "mps" network for Hubbard (with * 2 sites). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MPS (Matrix Product State) was available as a network architecture but not wired into the Hubbard or Ising model registries. Since MPS carries no symmetry constraints, it registers as
"mps"(no/u1or similar suffix).Changes
qmp/models/hubbard.py— addsMpsConfigwithvirtual_dim(bond dimension, default 16); usessites = m × n × 2to account for spin-up/spin-down orbitals per lattice siteqmp/models/ising.py— addsMpsConfigwithvirtual_dim(default 16); usessites = m × nBoth register under
Model.network_dict["mps"].Usage
Original prompt
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.