Fix wrong return type in set_bit in cuda kernel. - #37
Merged
Conversation
hzhangxyz
requested review from
CuSO4Deposit and
Copilot
and removed request for
Copilot
June 16, 2025 09:54
There was a problem hiding this comment.
Pull Request Overview
This PR updates the return type of the CUDA kernel function set_bit from bool to void, ensuring that the function correctly reflects its behavior of modifying data in-place without returning a value.
- Changes the signature of set_bit to return void.
- Ensures that the bit-setting operation updates the data correctly without using a return value.
Comments suppressed due to low confidence (1)
qmb/_hamiltonian_cuda.cu:45
- Changing the return type to void clarifies that the set_bit function is used solely for its side-effect. Ensure that any call sites expecting a bool return value are updated accordingly.
__device__ void set_bit(std::uint8_t* data, std::uint8_t index, bool value) {
1 task
CuSO4Deposit
approved these changes
Jun 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix wrong return type in
set_bitin cuda kernel.Checklist: