Remove thrust from dependencies of the cpu kernel. - #46
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR removes dependencies on the Thrust library by replacing thrust::sort and thrust::sort_by_key with std::sort, and updates the default comparator in a heap helper from thrust::less to std::less.
- Swapped out Thrust sorting functions for
std::sortand updated related code paths - Removed Thrust includes and updated the heap helper template comparator
Comments suppressed due to low confidence (1)
qmb/_hamiltonian_cpu.cpp:1
- After removing Thrust, you need to add
#include <algorithm>(and#include <functional>ifstd::lessisn't already covered) at the top to ensurestd::sortandstd::lessare defined.
#include <torch/extension.h>
5 tasks
hzhangxyz
requested review from
BrevityD,
CuSO4Deposit and
stevapple
and removed request for
CuSO4Deposit and
stevapple
June 18, 2025 04:22
|
为什么要remove |
Member
Author
@BrevityD 这个cpu的实现和cuda的实现,移除了cpu部分对thrust的依赖,让没有cuda没gpu的机子可以跑。 |
BrevityD
approved these changes
Jun 24, 2025
|
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist: