Skip to content

Add electron number into group name for Hubbard model. - #47

Merged
hzhangxyz merged 1 commit into
mainfrom
dev/add-electron-number-in-group-name-for-hubbard-model
Jun 20, 2025
Merged

Add electron number into group name for Hubbard model.#47
hzhangxyz merged 1 commit into
mainfrom
dev/add-electron-number-in-group-name-for-hubbard-model

Conversation

@hzhangxyz

Copy link
Copy Markdown
Member

Description

Checklist:

@hzhangxyz
hzhangxyz requested review from CuSO4Deposit and Copilot and removed request for Copilot June 18, 2025 07:58

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the naming of Hubbard model groups by appending the electron count to the default group name.

  • Updated default_group_name to include config.electron_number
  • No other functional changes
Comments suppressed due to low confidence (2)

qmb/hubbard.py:61

  • Consider updating the docstring for default_group_name to document that electron_number is now part of the naming convention.
        return f"Hubbard_{config.m}x{config.n}_t{config.t}_u{config.u}_e{config.electron_number}"

qmb/hubbard.py:61

  • Add or update a unit test for default_group_name to verify that the electron_number is correctly included in the output string.
        return f"Hubbard_{config.m}x{config.n}_t{config.t}_u{config.u}_e{config.electron_number}"

@hzhangxyz
hzhangxyz requested review from BrevityD and removed request for CuSO4Deposit June 19, 2025 01:32
@hzhangxyz
hzhangxyz merged commit 93f162d into main Jun 20, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants