Rename the class/function from compare to less in operator kernels. - #53
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors operator kernels by renaming the variable and template parameter from "compare" to "less" for improved clarity and consistency.
- Renamed variables from "compare" to "less" in binary search and heap insertion logic
- Updated template parameter names to reflect this change in both CUDA and CPU implementations
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| qmb/_hamiltonian_cuda.cu | Replaced "compare" with "less" and updated template names |
| qmb/_hamiltonian_cpu.cpp | Replaced "compare" with "less" and updated template names |
Member
Author
|
2333，我sed的，不可能漏。
msg-bq ***@***.***> 于2025年6月26日周四 16:12写道：
… ***@***.**** approved this pull request.
image.png (view on web)
<https://github.com/user-attachments/assets/7b6de6b0-0591-4c96-be01-f8c50bd753bf>
看起来数量是对的，两个文件，16+26-2（出现在同一行）
—
Reply to this email directly, view it on GitHub
<#53 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACYVYFZDXA7Z6LQVZEOEZG33FOTPFAVCNFSM6AAAAACAFAZ5NCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDSNRRGE3DMMZXG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist: