Avoid to invoke logging.info before calling logging.basicConfig. - #61
Merged
Conversation
When we call logging.info before calling logging.basicConfig, logging.basicConfig may fail, so in the previous code, if our electron number is missing, we would see an empty logging. So this commit does not logging the information about missing electron number instead to save the logging basic config.
There was a problem hiding this comment.
Pull Request Overview
This PR removes the logging.info call that was previously invoked before logging.basicConfig is set up, to avoid potential logging configuration issues. Additionally, the code comment for electron_number has been updated to clarify its behavior for half-filling.
- Removed the logging.info call in the post_init method.
- Updated the comment for electron_number to indicate it remains empty for half-filling.
Comments suppressed due to low confidence (1)
qmb/hubbard.py:40
- If the removed logging message provided valuable debugging information, consider documenting this behavior or reintroducing logging after logging.basicConfig is correctly set up.
self.electron_number = self.m * self.n
Member
Author
msg-bq
approved these changes
Jul 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When we call logging.info before calling logging.basicConfig, logging.basicConfig may fail, so in the previous code, if our electron number is missing, we would see an empty logging. So this commit does not logging the information about missing electron number instead to save the logging basic config.
Checklist: