Skip to content

Rename imag to haar to keep consistency with the paper. - #64

Merged
hzhangxyz merged 2 commits into
mainfrom
dev/rename-imag-to-haar
Jul 22, 2025
Merged

Rename imag to haar to keep consistency with the paper.#64
hzhangxyz merged 2 commits into
mainfrom
dev/rename-imag-to-haar

Conversation

@hzhangxyz

Copy link
Copy Markdown
Member

Description

Checklist:

@hzhangxyz
hzhangxyz force-pushed the dev/rename-imag-to-haar branch from d20a622 to 8a90840 Compare July 17, 2025 15:30
@hzhangxyz
hzhangxyz requested review from Copilot and msg-bq and removed request for msg-bq July 17, 2025 15:31

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR renames the imag subcommand to haar for consistency with the underlying paper. The change maintains backward compatibility by keeping the old imag functionality accessible while deprecating it.

Key changes:

  • Renamed ImaginaryConfig class to HaarConfig and updated all references
  • Added backward compatibility through a deprecated ImagConfig class that inherits from HaarConfig
  • Updated data structure keys and logging metrics from "imag" to "haar"

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
qmb/haar.py Renamed main config class, updated all data keys and logging references, added backward compatibility
qmb/main.py Updated import statement from imag to haar
Comments suppressed due to low confidence (1)

qmb/haar.py:528

  • The class name ImagConfig is inconsistent with the naming pattern. It should be ImaginaryConfig to match the original class name that was renamed to HaarConfig.
class ImagConfig(HaarConfig):

@hzhangxyz
hzhangxyz requested a review from msg-bq July 17, 2025 15:36
@hzhangxyz
hzhangxyz force-pushed the dev/rename-imag-to-haar branch from 8a90840 to da7b661 Compare July 17, 2025 15:38
@hzhangxyz
hzhangxyz requested a review from msg-bq July 22, 2025 07:21
@hzhangxyz
hzhangxyz merged commit 28553f9 into main Jul 22, 2025
2 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants