Rename imag to haar to keep consistency with the paper. - #64
Merged
Conversation
hzhangxyz
force-pushed
the
dev/rename-imag-to-haar
branch
from
July 17, 2025 15:30
d20a622 to
8a90840
Compare
hzhangxyz
requested review from
Copilot and
msg-bq
and removed request for
msg-bq
July 17, 2025 15:31
There was a problem hiding this comment.
Pull Request Overview
This PR renames the imag subcommand to haar for consistency with the underlying paper. The change maintains backward compatibility by keeping the old imag functionality accessible while deprecating it.
Key changes:
- Renamed
ImaginaryConfigclass toHaarConfigand updated all references - Added backward compatibility through a deprecated
ImagConfigclass that inherits fromHaarConfig - Updated data structure keys and logging metrics from "imag" to "haar"
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| qmb/haar.py | Renamed main config class, updated all data keys and logging references, added backward compatibility |
| qmb/main.py | Updated import statement from imag to haar |
Comments suppressed due to low confidence (1)
qmb/haar.py:528
- The class name
ImagConfigis inconsistent with the naming pattern. It should beImaginaryConfigto match the original class name that was renamed toHaarConfig.
class ImagConfig(HaarConfig):
hzhangxyz
force-pushed
the
dev/rename-imag-to-haar
branch
from
July 17, 2025 15:38
8a90840 to
da7b661
Compare
msg-bq
approved these changes
Jul 18, 2025
msg-bq
approved these changes
Jul 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist: