feat(db): make payment_hash and hash_index unique#13
Open
bogdanserdinov wants to merge 1 commit into
Open
Conversation
txalkan
requested changes
May 25, 2026
| status TEXT NOT NULL, | ||
| created_at DATETIME NOT NULL DEFAULT CURRENT_TIMESTAMP, | ||
| updated_at DATETIME NOT NULL DEFAULT CURRENT_TIMESTAMP, | ||
| UNIQUE(order_id, hash_index), |
Member
There was a problem hiding this comment.
Hi @bogdanserdinov,
Double-checking this: hash_index is only unique within an order, so enforcing UNIQUE(hash_index) is too strong. It makes values like 1 usable only once across the whole system, which will break the next peer/order that starts its pool at 1.
payment_hash can be globally unique as the intended invariant. Please make sure it's enforced where it's looked up and acted on, not only in async_hash_pool.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.