Skip to content

security: enforce IP-based rate limiting on WebSocket handshakes (#346)#528

Open
prakshithamalla-art wants to merge 2 commits into
UTKARSHH20:mainfrom
prakshithamalla-art:security/socket-rate-limiting
Open

security: enforce IP-based rate limiting on WebSocket handshakes (#346)#528
prakshithamalla-art wants to merge 2 commits into
UTKARSHH20:mainfrom
prakshithamalla-art:security/socket-rate-limiting

Conversation

@prakshithamalla-art

Copy link
Copy Markdown
Contributor

Closes #346

Changes Made:

  • WebSocket Handshake Interceptor: Implemented an io.use() global middleware block within backend/src/lib/socket.js to inspect and gate all incoming client connection requests prior to server event loop engagement.
  • Rolling Window Rate Limiter: Engineered a localized memory map (connectionRates) tracking client IP addresses (x-forwarded-for compatible). The system enforces a strict threshold envelope dropping IPs that attempt more than 5 rapid handshakes within a 10-second rolling window.
  • Resource Exhaustion Mitigation: Instantly drops malicious, high-frequency script attacks with a native Socket Error rejection, completely insulating the downstream routing infrastructure and database aggregations from DDoS memory exhaustion.
  • Minimal Diffs: The addition perfectly wraps the existing WebRTC and active presence infrastructure logic, leaving existing downstream events unmodified.

@coderabbitai

coderabbitai Bot commented Jun 8, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@prakshithamalla-art, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 53 minutes and 4 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 9d390ab5-3e04-488a-912e-3f97224b1a08

📥 Commits

Reviewing files that changed from the base of the PR and between 29c9c86 and b44b9c1.

📒 Files selected for processing (1)
  • backend/src/lib/socket.js
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@prakshithamalla-art

Copy link
Copy Markdown
Contributor Author

@UTKARSHH20 pls check it and merge it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Security] Enforce connection frequency rate-limiters on the WebSocket handshake gateway

1 participant