Application Management Implementation Frontend #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hasnain-saeed
force-pushed
the
hasnain/application-management-fe
branch
from
d54d4fb to
fbdda7a
Compare
hasnain-saeed
force-pushed
the
hasnain/application-management-fe
branch
from
fbdda7a to
55d513d
Compare
hasnain-saeed
changed the base branch from
hasnain/add-application-management
to
dev
Author
|
To better review the frontend code, #66 should be merged in dev first so that backend code isn't visible in the review |
ebinbellini
reviewed
Dec 14, 2025
| <button | ||
| type="button" | ||
| className={`button ${styles.applyButton}`} | ||
| disabled={position.user_app_status !== ""} |
There was a problem hiding this comment.
This button becomes disabled when I have saved a draft or submitted. Also the button says "In Progress" when I have a draft, which is a bit unclear. Also, it should be gray according to the design. If it's blue it sticks out too much when there are multiple open roles.
Author
There was a problem hiding this comment.
I wanted user to navigate to My Applications tab but yes we can navigate directly to the in-progress application form from there.
| @@ -35,7 +33,12 @@ const ApplicationCard = ({ application }: Props) => { | |||
| </div> | |||
There was a problem hiding this comment.
Can we get the same date format that's used in the design document, e.g. Dec. 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented complete application management UI with draft/submit workflow, reference management, and responsive design.
PR #66 should be merged first before this