Fix aug_func() got an unexpected keyword argument 'obs_type'#12
Closed
titanium-47 wants to merge 1 commit intoUW-Lab:mainfrom
Closed
Fix aug_func() got an unexpected keyword argument 'obs_type'#12titanium-47 wants to merge 1 commit intoUW-Lab:mainfrom
titanium-47 wants to merge 1 commit intoUW-Lab:mainfrom
Conversation
Collaborator
|
Thanks for reporting this Sid! I believe this issue should be fixed in PR #13. Closing this for now, but feel free to reopen it if you still see problems |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rsl_rl's ppo implementation passes keyword
obs_typeinto the data augmentation function rather than keywordis_critic. Therefore I modifiedaug_functo accept the keywordobs_typerather thanis_critic. This change has been tested by runningtrain.pywith theUW-Position-Pit-Spot-v0environment.