Skip to content

chore(apollo-react): render StageNode stories at production stage width (336)#931

Merged
kittyyueli merged 1 commit into
mainfrom
claude/slack-message-help-wm96z8
Jul 20, 2026
Merged

chore(apollo-react): render StageNode stories at production stage width (336)#931
kittyyueli merged 1 commit into
mainfrom
claude/slack-message-help-wm96z8

Conversation

@kittyyueli

@kittyyueli kittyyueli commented Jul 19, 2026

Copy link
Copy Markdown
Member

What & why

Case Management stages in Maestro (PO.Frontend) are moving from 304px to 336px wide per MST-12509. The StageNode component in apollo-react is already width-agnostic (it renders at the width prop, with min-width: 288px), so no component change is needed. Its Storybook stories, however, hardcoded the old 304px, so Storybook rendered stages narrower than production. This updates the stories to the new width so Storybook matches the product.

Changes

  • StageNode.stories.tsx — introduce a DEFAULT_STAGE_WIDTH = 336 constant and point every stage-node story at it. Previously there were 46 hardcoded 304 widths plus 2 352 demo stages; all now resolve through the one constant, so future width changes are a one-line edit.
  • CanvasPerformance.stories.tsxPERFORMANCE_STAGE_NODE_WIDTH 304 → 336.

No change to StageNode runtime behavior or to the published package. Story data only. Sticky-note widths, loop-node heights, and node y-positions that also happened to be 304 were intentionally left untouched.

Visual regression

These stories drive the Playwright visual snapshots, so the StageNode and CanvasPerformance baselines will shift by design. No baseline images are committed in-repo, so the visual-regression job will need its snapshots regenerated/approved on this PR.

Context

Part of MST-12509. The product-side change (a per-case useNewStageWidth flag, gated behind a canvas-useNewStageWidth feature flag) lands in PO.Frontend separately so existing cases keep their current width with no migration.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Be4BTjmo7bosdUf8UTZ7DV


Generated by Claude Code

…th (336)

Case-management stages in Maestro are moving from 304px to 336px wide
(MST-12509). Update the StageNode and CanvasPerformance stories to render
at the new width so Storybook matches the product.

Introduces a DEFAULT_STAGE_WIDTH constant in the StageNode stories so the
value lives in one place instead of being repeated across every story. All
stage nodes in the stories, including the previously 352px demo stages, now
use this constant.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Be4BTjmo7bosdUf8UTZ7DV
Copilot AI review requested due to automatic review settings July 19, 2026 04:02
@github-actions

github-actions Bot commented Jul 19, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (PT)
apollo-design 🟢 Ready Preview, Logs Jul 18, 2026, 09:07:34 PM
apollo-docs 🟢 Ready Preview, Logs Jul 18, 2026, 09:07:34 PM
apollo-landing 🟢 Ready Preview, Logs Jul 18, 2026, 09:07:34 PM
apollo-vertex 🟢 Ready Preview, Logs Jul 18, 2026, 09:07:34 PM

@github-actions

Copy link
Copy Markdown
Contributor

Dependency License Review

  • 1950 package(s) scanned
  • ✅ No license issues found
  • ⚠️ 2 package(s) excluded (see details below)
License distribution
License Packages
MIT 1720
ISC 89
Apache-2.0 55
BSD-3-Clause 27
BSD-2-Clause 23
BlueOak-1.0.0 8
MPL-2.0 4
MIT-0 3
CC0-1.0 3
MIT OR Apache-2.0 2
(MIT OR Apache-2.0) 2
Unlicense 2
LGPL-3.0-or-later 1
Python-2.0 1
CC-BY-4.0 1
(MPL-2.0 OR Apache-2.0) 1
Unknown 1
Artistic-2.0 1
(WTFPL OR MIT) 1
(BSD-2-Clause OR MIT OR Apache-2.0) 1
CC-BY-3.0 1
0BSD 1
(MIT OR CC0-1.0) 1
MIT AND ISC 1
Excluded packages
Package Version License Reason
@img/sharp-libvips-linux-x64 1.2.4 LGPL-3.0-or-later LGPL pre-built binary, not linked
khroma 2.1.0 Unknown MIT per GitHub repo, missing license field in package.json

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates Storybook canvas stories in apollo-react so StageNode renders at the new Maestro production stage width (336px), keeping visual snapshots aligned with the product while leaving runtime component behavior unchanged.

Changes:

  • Added DEFAULT_STAGE_WIDTH = 336 to StageNode.stories.tsx and routed stage node widths through it (eliminating hardcoded widths).
  • Updated CanvasPerformance.stories.tsx performance stage node width from 304 → 336.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
packages/apollo-react/src/canvas/components/StageNode/StageNode.stories.tsx Introduces a single default stage width constant and applies it across StageNode stories for consistent Storybook rendering.
packages/apollo-react/src/canvas/components/CanvasPerformance.stories.tsx Updates the performance story’s stage-node width constant to match the new production width.

@github-actions

Copy link
Copy Markdown
Contributor

📊 Coverage + size by package

Per-package coverage and bundle size on this PR. New-line coverage = of the source lines this PR adds or changes, the % hit by tests.

Package Coverage New-line coverage Packed (gzip) Unpacked vs main
@uipath/apollo-core 9.0% 43.82 MB 57.31 MB ±0
@uipath/apollo-react 37.2% 0.0% (0/2) 7.38 MB 28.15 MB ±0
@uipath/apollo-wind 40.3% 395.2 KB 2.57 MB +17 B
@uipath/ap-chat 85.8% 43.43 MB 55.92 MB ±0

"Coverage" is each package's own coverage.include scope (e.g. apollo-core instruments only scripts/). "Packed"/"Unpacked" come from npm pack --dry-run and only cover built packages — "—" means not measured this run (package not affected / not built). "vs main" is the packed (gzipped) delta against the last successful main build (the package-sizes artifact from the Release workflow); "—" there means no main baseline was available this run. The baseline is main's latest build, not this PR's exact merge-base, so it includes any drift since the branch diverged. Packages with no vitest config are omitted.

@kittyyueli
kittyyueli merged commit 7ccd136 into main Jul 20, 2026
39 of 40 checks passed
@kittyyueli
kittyyueli deleted the claude/slack-message-help-wm96z8 branch July 20, 2026 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg:apollo-react size:L 100-499 changed lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants