Skip to content

fix(apollo-wind): suppress native search clear button to avoid duplicate #972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
david-rios-uipath merged 2 commits into from
Jul 25, 2026
+11 −1
Merged

fix(apollo-wind): suppress native search clear button to avoid duplicate #972

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
522369c
fix(apollo-wind): suppress native search clear button to avoid duplic…
david-rios-uipath Jul 24, 2026
95195c0
test(apollo-wind): assert Search keeps native-clear-button suppressio…
david-rios-uipath Jul 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/apollo-wind/src/components/ui/search.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,13 @@ describe('Search', () => {
expect(input).toHaveClass('custom-search');
});

it('suppresses the native search clear button to avoid a duplicate', () => {
render(<Search value="test" onChange={vi.fn()} />);
const input = screen.getByRole('searchbox');
expect(input).toHaveClass('[&::-webkit-search-cancel-button]:appearance-none');
expect(input).toHaveClass('[&::-webkit-search-decoration]:appearance-none');
});

it('forwards ref correctly', () => {
const ref = { current: null };
render(<Search ref={ref} />);
Expand Down
5 changes: 4 additions & 1 deletion packages/apollo-wind/src/components/ui/search.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,10 @@ const Search = React.forwardRef<HTMLInputElement, SearchProps>(
<InputGroupInput
ref={ref}
type="search"
className={className}
className={cn(
'[&::-webkit-search-cancel-button]:appearance-none [&::-webkit-search-decoration]:appearance-none',
className
)}
Comment thread
david-rios-uipath marked this conversation as resolved.
value={value}
onChange={(e) => onChange?.(e.target.value)}
{...props}
Expand Down
Loading