Skip to content

fix(skill_triggered): detect skill engagement by regex, not the Skill tool#17

Closed
Mihaiii wants to merge 1 commit into
mainfrom
fix/general-harness-no-skill-tool
Closed

fix(skill_triggered): detect skill engagement by regex, not the Skill tool#17
Mihaiii wants to merge 1 commit into
mainfrom
fix/general-harness-no-skill-tool

Conversation

@Mihaiii

@Mihaiii Mihaiii commented Jul 13, 2026

Copy link
Copy Markdown

Neither Antigravity CLI nor Codex CLI has a Skill tool — only Claude Code does. Both engage a skill by reading its SKILL.md off disk: Antigravity via its file-view/read tool (view_file -> Read), Codex via shell (cat/sed, recorded as Bash).

Detection now matches a skill-specific regex over the serialized command parameters instead of inspecting cmd.tool_name == "Skill".

This scores identically across all agents and requires no Skill tool.

Add tests for a Read tool whose path ends in SKILL.md (Antigravity's .agents/skills/ layout) and a guard that a SKILL.md outside any skill dir does not false-positive.

… tool

Neither Antigravity CLI nor Codex CLI has a Skill tool — only Claude Code
does. Both engage a skill by reading its SKILL.md off disk: Antigravity via
its file-view/read tool (view_file -> Read), Codex via shell (cat/sed,
recorded as Bash). The Delegate SDK harness likewise has no Skill tool.

Detection now matches a skill-specific regex over the serialized command
parameters instead of inspecting cmd.tool_name == "Skill":

  skills/<name>/            # skill files read off disk (repo path or
                            # .agents/skills/ symlink), any tool's params
  "skill": "<name>"         # Claude's Skill-tool arg, optionally namespaced

This scores identically across all agents and requires no Skill tool.

Add tests for a Read tool whose path ends in SKILL.md (Antigravity's
.agents/skills/ layout) and a guard that a SKILL.md outside any skill dir
does not false-positive.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@github-actions

github-actions Bot commented Jul 13, 2026

Copy link
Copy Markdown

Claude finished @Mihaiii's task in 1m 50s —— View job


Code Review In Progress

Todo List:

  • Read code review guidelines from .github/code_review.md
  • Read project conventions from CLAUDE.md
  • Get the full PR diff
  • Read complete changed files for context
  • Perform detailed code review
  • Post review feedback

@Mihaiii

Mihaiii commented Jul 13, 2026

Copy link
Copy Markdown
Author

Closing as redundant.

@Mihaiii Mihaiii closed this Jul 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant