fix: detect Windows skill paths in telemetry#24
Open
dmorosanu wants to merge 1 commit into
Open
Conversation
|
Claude finished @dmorosanu's task in 1m 36s —— View job Code Review in Progress
|
bai-uipath
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Fix
skill_triggereddetection for Codex telemetry containing Windows paths.Problem
Codex records skill reads inside PowerShell command strings using backslashes, sometimes retained as doubled JSON-escaped separators. The checker only recognized
skills/<name>/, so a skill could be loaded correctly while the evaluation incorrectly reportedobserved=no. Final scoring and early-stop detection also used separate matching paths, allowing their results to diverge.Change
Use one shared detector for final scoring and early-stop behavior. It accepts POSIX separators, Windows separators, doubled escaped separators, and overlapping repository paths such as
skills/skills/<name>/.Validation
127 passed:tests/test_skill_triggered.pyandtests/test_early_stop.pyskill_triggeredasobserved=yes, score1.0