Skip to content

fix: detect Windows skill paths in telemetry#24

Open
dmorosanu wants to merge 1 commit into
mainfrom
codex/fix-skill-triggered-windows
Open

fix: detect Windows skill paths in telemetry#24
dmorosanu wants to merge 1 commit into
mainfrom
codex/fix-skill-triggered-windows

Conversation

@dmorosanu

Copy link
Copy Markdown

Summary

Fix skill_triggered detection for Codex telemetry containing Windows paths.

Problem

Codex records skill reads inside PowerShell command strings using backslashes, sometimes retained as doubled JSON-escaped separators. The checker only recognized skills/<name>/, so a skill could be loaded correctly while the evaluation incorrectly reported observed=no. Final scoring and early-stop detection also used separate matching paths, allowing their results to diverge.

Change

Use one shared detector for final scoring and early-stop behavior. It accepts POSIX separators, Windows separators, doubled escaped separators, and overlapping repository paths such as skills/skills/<name>/.

Validation

  • 127 passed: tests/test_skill_triggered.py and tests/test_early_stop.py
  • Ruff lint and formatting passed
  • Rechecked the four original troubleshoot trajectories: all report skill_triggered as observed=yes, score 1.0
  • Fresh four-test end-to-end run: activation passed in all four scenarios

@dmorosanu dmorosanu marked this pull request as ready for review July 14, 2026 15:16
@github-actions

github-actions Bot commented Jul 14, 2026

Copy link
Copy Markdown

Claude finished @dmorosanu's task in 1m 36s —— View job


Code Review in Progress

Review Checklist:

  • Read .github/code_review.md for review standards
  • Read CLAUDE.md for project conventions
  • View full PR diff (origin/main...HEAD)
  • Read complete changed files for context
  • Analyze code changes for correctness
  • Check cross-file consistency
  • Perform "what's missing" analysis
  • Provide design-level scrutiny
  • Format review per code_review.md guidelines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants