Add InvokeWorkflowFile troubleshooting playbook coverage (design-time + runtime)#2104
Add InvokeWorkflowFile troubleshooting playbook coverage (design-time + runtime)#2104Stefan-Virgil wants to merge 2 commits into
Conversation
|
Claude finished @Stefan-Virgil's task in 3m 52s —— View job PR Review: InvokeWorkflowFile Troubleshooting Coverage
SummaryAdds comprehensive Change-by-Change Review1.
|
| Area | Status | Notes |
|---|---|---|
| Frontmatter | OK | No SKILL.md changes; playbook frontmatter valid |
| E2E Tests | Issue | Missing required lifecycle:discover tag on all 9 tasks |
| Skill Body | OK | Playbooks are well-structured with clean cross-references |
| References & Assets | OK | All links resolve; summary table updated |
| Repo Hygiene | OK | No secrets, no cross-skill deps, CODEOWNERS covered, scrub pass clean |
Issues for Manual Review
- Domain accuracy of XAML fixtures: The crafted
.xamlfiles embed UiPath-specific properties (ArgumentsVariable,UnSafe,TargetSession,ExecutionMode="Suspend"). I verified the properties are consistently referenced between the XAML source and the error messages in the JSON fixtures, but the reviewer should confirm the attribute names and values match the actual UiPath SDK behavior. - 33/33 passing runs claimed in PR description: The validation results are not independently verifiable from the PR diff. Consider linking the evalboard run or attaching run artifacts.
Conclusion
Strong PR — thorough coverage of a previously untested activity with well-crafted faithful-replay scenarios. The single actionable finding is the missing lifecycle:discover tag on all 9 task YAMLs, which is required per the tag taxonomy and consistently present on all existing troubleshoot tasks. Recommend fixing that and then this is good to merge.
|
|
Claude finished @Stefan-Virgil's task in 3m 10s —— View job Coder-eval task lint (advisory)
Coder-eval task lint (advisory)9 task YAMLs changed; verdict counts: 0 Critical, 0 High, 0 Medium, 0 Low, 9 OK. Rubric: .claude/commands/lint-task.md. This check is advisory and never blocks merge. Evidence of passing run✅ Author confirms passing run: "Every scenario validated with 3 parallel coder-eval replicates ( Per-task lint
|
|
Addressed the review finding in fd214b3: added the required
Minor note for the record: the older troubleshoot tasks in this directory (e.g. |
… + runtime) Errors on UiPath.Core.Activities.InvokeWorkflowFile had only a single runtime "invoke faulted" playbook and no test coverage. Add a dedicated design-time playbook, complete the runtime playbook, and lock in both with faithful-replay coder-eval scenarios. Playbook (classic-activities): - New invoke-workflow-file-design-time-errors.md: unknown-member ArgumentsVariable (package-version), Cache Mechanism Error code 7, invoked .xaml outside project root, unmapped required argument, plus the maintenance checklist. - Complete invoke-workflow-failed.md: add the persistence-not-supported branch (previously only a symptom, no cause/investigation/resolution) and ignoredFiles / UnSafe / TargetSession specifics. - Cross-redirect the two playbooks so design-time vs runtime route cleanly; each error signature resolves to one dominant playbook. Tests (9 e2e scenarios, skill_triggered + llm_judge): - Design-time (4): unknown-member, cache-error-7, file-not-packed, arg-required. - Runtime (5): child-throws (one-hop tracing), arg-mismatch, session-isolated, ignored-file, persistence. - All validated with 3 parallel replicates each (33 runs, all passing). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Address PR review: the repo tag taxonomy (tests/README.md) requires a lifecycle:* tag on every task; diagnostic investigations are read-only exploration, so lifecycle:discover — matching the current db-* troubleshoot scenarios. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
fd214b3 to
e076c98
Compare
What
Comprehensive troubleshooting coverage for
UiPath.Core.Activities.InvokeWorkflowFile, which previously had a single runtime "invoke faulted" playbook and zero test coverage.Playbook (classic-activities)
invoke-workflow-file-design-time-errors.md— Studio design/build-time errors: unknown-memberArgumentsVariable(package-version mismatch), Cache Mechanism Error code 7, invoked.xamloutside the project root, unmapped required argument, plus the maintenance checklist (re-add activity, fix double-backslashes, rebuildproject.json).invoke-workflow-failed.md— added the persistence-not-supported branch (it was listed only as a symptom, with no cause/investigation/resolution), plusignoredFiles/UnSafe/TargetSessionspecifics. Property names verified against the repo's own activity docs.Tests — 9 e2e scenarios (
skill_triggered+llm_judge, canonical troubleshoot shape)classic-invoke-unknown-memberArgumentsVariable)classic-invoke-cache-error-7classic-invoke-file-not-packed.xamloutside project rootclassic-invoke-arg-requiredclassic-invoke-child-throwsclassic-invoke-arg-mismatchArgumentExceptionclassic-invoke-session-isolatedCurrentTargetSession+UnSafe=Falseclassic-invoke-ignored-file.xamlinignoredFiles→ runtime FNFclassic-invoke-persistenceRunJobSuspend +supportsPersistence: falseValidation
Every scenario validated with 3 parallel coder-eval replicates (
experiments/default.yaml). 33/33 runs SUCCESS; all criteria 1.0 except one cache-error replicate at 0.90 (still well above the 0.7 threshold — judge noted a slightly vague fix on that run).Notes
jobs get/logs/history/traces+folders/jobs list), design-time scenarios are source-only withdocsaipassthrough.🤖 Generated with Claude Code