fix(uipath-feedback): send description via --description-file, not inline multi-line arg [PILOT-6404]#2114
Conversation
…line multi-line arg [PILOT-6404] Windows PowerShell 5.1 cannot serialize a multi-line --description into the single command-line string a native command receives, so the skill's bash-heredoc invocation split the markdown bullet lines into options (ValidationError) and the send silently fell back to a local file. Write the sanitized body to a temp file with the Write tool and pass --description-file, which is immune to shell quoting on PowerShell, cmd, and bash. Add guidance to diagnose a shell-quoting failure as such instead of blaming the CLI. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Consider adding smoke tests before merging. |
|
Claude finished @gabrielavaduva's task in 2m 17s —— View job PR Review: fix(uipath-feedback) —
|
| Area | Status | Notes |
|---|---|---|
| Frontmatter | OK | Not modified; still valid |
| E2E Tests | Pre-existing gap | No tests/tasks/uipath-feedback/ directory |
| Skill Body | OK (1 Medium) | Temp file cleanup gap |
| References & Assets | OK | No reference files changed |
| Repo Hygiene | OK | No secrets, no cross-skill deps, change is well-scoped |
Issues for Manual Review
- CLI dependency. The PR description notes this depends on
UiPath/cli#3129adding--description-file. Confirm that CLI change has merged (or will merge first) so agents don't hit an unknown-flag error. The stdin fallback instruction provides some safety net, but it's intentionally vague. - Verify
--description-fileflag name. Cannot confirm the exact flag name matches what the CLI actually ships — verify against the CLI's help output or the linked PR.
Conclusion
Clean, well-motivated fix for a real cross-platform failure. The core change (heredoc → Write tool + --description-file) is correct and the added agent guidance (diagnosis paragraph, tightened fallback) is valuable. One Medium finding: the description temp file at <temp>/uip-feedback/ isn't cleaned up by the existing rm -rf that only targets uip-feedback-attachments/. Worth fixing before merge. Otherwise looks good.
Why
The
uipath-feedbackskill's Step 4 built the CLI call with a bash-only heredoc ($(cat <<'FEEDBACK_EOF' … )). On Windows PowerShell that syntax doesn't exist, and inlining the multi-line markdown as--description "…"is mangled by PS 5.1's native-argument serializer (bullet lines become options →ValidationError). The agent then retried five variants of the same broken pattern, misdiagnosed it as a CLI bug, and silently fell back to writingfeedback-report.md— the feedback was never sent. This is PILOT-6404.What
--description-file, which is immune to shell quoting on PowerShell, cmd, and bash.ValidationErroras such instead of blaming the CLI or retrying the inline form.Companion / ordering
Depends on the CLI adding
--description-file(UiPath/cli#3129). That should merge/release first; the skill notes a stdin fallback for older CLIs.🤖 Generated with Claude Code