test(maestro-case): cover inline resource creation#2117
Conversation
26a5b03 to
6d244f1
Compare
|
Claude finished @song-zhao-25's task in 2m 24s —— View job PR Review: test(maestro-case): cover inline resource creation
SummaryAdds two well-structured E2E test tasks for Change-by-Change Review1.
|
| Area | Status | Notes |
|---|---|---|
| Frontmatter | N/A | No skill changes — test-only PR |
| E2E Tests | OK | Two well-structured e2e tasks with deterministic checkers |
| Skill Body | N/A | No skill changes |
| References & Assets | OK | SDD fixtures are minimal and correct |
| Repo Hygiene | OK | No secrets, no cross-skill deps, CODEOWNERS covered |
Issues for Manual Review
- The PR body notes the API task's latest local run is "red on a separate skill-output defect" (the generated greeting extraction omits
originalVar). This is a known skill-side issue, not a test defect — the grader intentionally retains theoriginalVarassertion because the skill contract marks it as load-bearing. Worth tracking whether the skill fix lands before this test is expected to pass in CI.
Conclusion
Clean PR. The two E2E tasks are well-designed, properly tagged, and thoroughly validated by deterministic Python checkers that reuse the shared case_check module. The only minor inconsistency is the missing check=False in the API checker's subprocess.run call — a polish item that doesn't affect correctness. Approve.
|
Claude finished @song-zhao-25's task in 3m 12s —— View job Coder-eval task lint (advisory)2 task YAMLs changed; verdict counts: 0 Critical, 0 High, 0 Medium, 0 Low, 2 OK. Rubric: .claude/commands/lint-task.md. This check is advisory and never blocks merge. Evidence of passing run
Per-task lint
|
6d244f1 to
0df8009
Compare
Summary
customerName:stringinput andgreeting:stringoutput wiring across the case/resource boundaryAgent-tool delegation, sibling registration, local registry audit, and valid case bindingsValidation
coder-eval 0.8.3 planfor both task YAMLsscripts/check-cli-verbs.py --jsonfor both task YAMLsgit diff --check1.000: run 29621632043CreateMissingApiWorkflowCaseProject0.8.3: case-project discovery/validation passed; full checker correctly failed because the generated output mapping omitted load-bearingoriginalVar: "greeting"Live E2E status
The revised agent task passes end to end. The API task now tolerates valid Case Management project folder names by resolving the single
CaseManagementproject from the solution manifest. Its latest local run remains red on a separate skill-output defect: the generated greeting extraction omittedoriginalVar, even though case validation passed. The grader intentionally retains this assertion because the skill contract marksoriginalVaras load-bearing.