Skip to content

fix(maestro-case-tests): avoid pytest module collision#2120

Merged
song-zhao-25 merged 1 commit into
mainfrom
fix/maestro-case-pytest-module-collision
Jul 20, 2026
Merged

fix(maestro-case-tests): avoid pytest module collision#2120
song-zhao-25 merged 1 commit into
mainfrom
fix/maestro-case-pytest-module-collision

Conversation

@song-zhao-25

Copy link
Copy Markdown
Contributor

Summary

  • rename the CM Golden checker unit-test module to a unique basename
  • prevent pytest default import-mode collision with the Athena test_checkers module
  • leave the coder-eval grader command unchanged

Validation

  • pytest tests/tasks/uipath-maestro-case/ -v — 21 passed
  • python3 tests/tasks/uipath-maestro-case/golden_rebuild/cm_golden_expense/test_cm_golden_expense_checkers.py — 4 passed

@github-actions

github-actions Bot commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Claude finished @song-zhao-25's task in 1m 14s —— View job


Reviewing PR #2120

  • Read review criteria and project conventions
  • Examine the diff and changed files
  • Read full file context
  • Check for cross-skill references, secrets, and link validity
  • Post review feedback

Summary

Pure file rename: test_checkers.pytest_cm_golden_expense_checkers.py in tests/tasks/uipath-maestro-case/golden_rebuild/cm_golden_expense/. This prevents a pytest default-import-mode collision with the identically-named tests/tasks/uipath-maestro-case/athena_cm_event/test_checkers.py. No content changes (0 additions, 0 deletions).

Change-by-Change Review

1. tests/tasks/uipath-maestro-case/golden_rebuild/cm_golden_expense/test_cm_golden_expense_checkers.py (RENAMED)

Severity: OK

  • The rename is correct. Two test_checkers.py modules in sibling directories under tests/tasks/uipath-maestro-case/ collide under pytest's default (prepend) import mode because both resolve to the same module name test_checkers. The Athena module at athena_cm_event/test_checkers.py still exists, so this rename disambiguates the CM-Golden copy.
  • The new name test_cm_golden_expense_checkers.py follows the directory's existing naming convention (cm_golden_expense.yaml, check_cm_golden_*.py).
  • File content is unchanged (similarity index 100%).
  • The coder-eval task YAML (cm_golden_expense.yaml) does not reference this test file — it only calls the check_cm_golden_*.py grader scripts via run_command, so the rename has no impact on the grading pipeline.
  • No remaining references to the old test_checkers basename exist anywhere in the tests/ tree (verified via grep).

What's Missing

Nothing identified.

Area Ratings

Area Status Notes
Frontmatter N/A No skill files changed
E2E Tests OK Rename only; grader commands unaffected
Skill Body N/A No skill files changed
References & Assets N/A No skill files changed
Repo Hygiene OK Scoped change, no secrets, no cross-skill deps

Issues for Manual Review

None found.

Conclusion

Clean, minimal fix. The rename resolves a real pytest module collision without touching any file content or grader configuration. No issues found — approve.


@song-zhao-25
song-zhao-25 merged commit 6aef015 into main Jul 20, 2026
21 checks passed
@song-zhao-25
song-zhao-25 deleted the fix/maestro-case-pytest-module-collision branch July 20, 2026 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants