fix(case): enforce bindings_v2 parity before validation#2128
Conversation
|
Claude finished @song-zhao-25's task in 2m 46s —— View job PR Review: fix(case): enforce bindings_v2 parity before validation
SummaryThis PR adds a mandatory semantic parity check ("Check 7") between Change-by-Change Review1.
|
| Area | Status | Notes |
|---|---|---|
| Frontmatter | OK | name matches folder, description unchanged and under 1024 chars |
| E2E Tests | OK | Existing test updated; no new untested capabilities |
| Skill Body | OK | Rule 14 rewritten cleanly; phase outlines updated consistently |
| References & Assets | OK | All 6 reference files updated in lockstep; Check 7 section well-structured; all relative links resolve |
| Repo Hygiene | OK | No cross-skill references, no secrets, no unrelated changes, CODEOWNERS already covers this path |
Issues for Manual Review
- Domain accuracy of Check 7 semantics: The review cannot verify that the 5-step comparison procedure (version check, resource-key cardinality, value/metadata shape match) is correct against the actual CLI behavior of
uip solution resources refresh. The procedure is internally consistent with the existing§ Regeneratesection, but the semantic comparison rules (step 3) should be validated against a real build. - Step 9.4 timing: The PR references "Step 9.4" for Phase 2 bindings_v2 regeneration. This step exists in
implementation.mdand appears to be correctly placed, but the reviewer cannot verify it runs at the right point in the build sequence relative to all task-type bindings being written.
Conclusion
Clean, well-scoped PR. The change is internally consistent across all 9 files — every reference to Rule 14, Check 7, and the parity guard points to the same anchors and uses the same semantics. The new Check 7 section in bindings-v2-sync.md is well-structured with clear halt conditions and no ambiguity. The TodoWrite addition to the test task is justified by the comment. No issues found — approve.
|
Claude finished @song-zhao-25's task in 2m 22s —— View job Coder-eval task lint (advisory)1 task YAML changed; verdicts: 0 Critical, 0 High, 0 Medium, 0 Low, 1 OK. One PR-level note on passing-run evidence. Rubric: .claude/commands/lint-task.md. This check is advisory and never blocks merge. Evidence of passing run
Per-task lint
|
d90f5be to
369c050
Compare
phased-execution.md still enumerated the end-of-Phase-3 validator as Checks 1-6 with an unconditional 'Never HALT' — an agent driving Phase 3 from that list would never run the new bindings-sidecar parity check, leaving bindings_v2.json empty exactly as in the failed CM-Golden run. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Summary
bindings_v2.json.resources[]with the complete projection ofcaseplan.json.bindings[]uip solution resources refreshphased-execution.md(the Phase 3 execution-order contract) with the new check: "Checks 1-6 … Never HALT" would have steered agents past Check 7 entirelyWhy
The remote CM golden expense run had populated caseplan bindings but an empty
bindings_v2.json.resources[]. The existing regeneration recipe was skipped, and no terminal validation prevented the run from continuing.Since SKILL.md Rule 11 designates
phased-execution.mdas the full phase contract, its validator line also had to enumerate Check 7 and carve out its halt-on-persistent-mismatch — otherwise the sole enforcement point for build-only runs stays unreachable.Validation
caseplan.json: projected sidecar carries all 6 expected resource keys + both connection IDs, satisfying every remainingcheck_cm_golden_bindings.pyassertionThis PR changes three documentation files: 5 insertions and 4 deletions.
🤖 Generated with Claude Code