fix: fail guardrail validation only when all rules are violated #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valentinabojan
force-pushed
the
guardrails_validation_messages
branch
2 times, most recently
from
f34cb78 to
f9496a3
Compare
valentinabojan
commented
Jan 20, 2026
| if violation_detected: | ||
| operator = ( | ||
| _humanize_guardrail_func(rule.detects_violation) or "violation check" | ||
| if not violation_detected: |
Contributor
Author
There was a problem hiding this comment.
If any of the fields don't violate the guardrail condition, then the validation should pass
valentinabojan
commented
Jan 20, 2026
| return True, reason | ||
|
|
||
| return True, "All word rule validations passed" | ||
| return False, get_validated_conditions_description( |
Contributor
Author
There was a problem hiding this comment.
Only when all fields violate the guardrail condition, then the validation should fail
valentinabojan
commented
Jan 20, 2026
|
|
||
| if not passed: | ||
| validated_conditions.append(reason) | ||
| if passed: |
Contributor
Author
There was a problem hiding this comment.
If any of the rules is not violated, then the validation should pass
valentinabojan
commented
Jan 20, 2026
| return GuardrailValidationResult( | ||
| result=GuardrailValidationResultType.PASSED, | ||
| reason="All deterministic guardrail rules passed", | ||
| result=GuardrailValidationResultType.VALIDATION_FAILED, |
Contributor
Author
There was a problem hiding this comment.
Only when all rules are violated, then the validation should fail
valentinabojan
changed the title
valentinabojan
force-pushed
the
guardrails_validation_messages
branch
from
2542fe5 to
cc9197f
Compare
added 2 commits
January 20, 2026 16:25
valentinabojan
force-pushed
the
guardrails_validation_messages
branch
2 times, most recently
from
d4ef5b6 to
ef04db0
Compare
apetraru-uipath
approved these changes
Jan 20, 2026
ctiliescuuipath
approved these changes
Jan 20, 2026
valentinabojan
force-pushed
the
guardrails_validation_messages
branch
from
ef04db0 to
711efc0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply multiple fixes regarding deterministic guardrails evaluation: