feat(errors): add ModelNotFoundError for discovery-miss lookups#116
Merged
Conversation
get_model_info raised a bare ValueError when a model name was absent from the discovery API response, indistinguishable from the other ValueErrors the factory/settings code can raise (unsupported vendor, missing agenthub_config, invalid kwargs). Callers had to match on the error message text to detect this specific case. Add ModelNotFoundError, raised by get_model_info on a discovery-miss. It subclasses ValueError (so existing `except ValueError` handlers keep working) and UiPathError (so it is catchable across the UiPath LLM error taxonomy) and carries the new UiPathLLMErrorCode.MODEL_NOT_FOUND code. Bumps core and langchain-client to 1.17.1, raises the langchain-client uipath-llm-client floor to >=1.17.1, and adds changelog entries.
tudormatei1
requested review from
DragosBobolea,
cosminacho,
cristipufu,
dragosvelcea,
ionmincu,
ionut-mihalache-uipath,
radu-mocanu and
vldcmp-uipath
as code owners
July 17, 2026 13:11
ionut-mihalache-uipath
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_model_info raised a bare ValueError when a model name was absent from the discovery API response, indistinguishable from the other ValueErrors the factory/settings code can raise (unsupported vendor, missing agenthub_config, invalid kwargs). Callers had to match on the error message text to detect this specific case.
Add ModelNotFoundError, raised by get_model_info on a discovery-miss. It subclasses ValueError (so existing
except ValueErrorhandlers keep working) and UiPathError (so it is catchable across the UiPath LLM error taxonomy) and carries the new UiPathLLMErrorCode.MODEL_NOT_FOUND code.Bumps core and langchain-client to 1.17.1, raises the langchain-client uipath-llm-client floor to >=1.17.1, and adds changelog entries.